.Net: Net: PromptTemplateConfig and IPromptTemplate namesapce refactor#3174
Merged
markwallace-microsoft merged 7 commits intomicrosoft:mainfrom Oct 16, 2023
Conversation
markwallace-microsoft
added
the
PR: breaking change
shawncal
added
.NET
github-actions
bot
changed the title
SergeyMenshykh
approved these changes
Oct 16, 2023
dmytrostruk
approved these changes
Oct 16, 2023
markwallace-microsoft
deleted the
users/markwallace/refactor_semanticfunctions_namespace
branch
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
microsoft#3174) ### Motivation and Context Resolves: microsoft#3173 ### Description - Move `IPromptTemplate` to namespace `Microsoft.SemanticKernel.TemplateEngine` - Move `PromptTemplate` and `PromptTemplateConfig` to namespace `Microsoft.SemanticKernel.TemplateEngine` - Eliminate `Microsoft.SemanticKernel.SemanticFunctions` namespace - Remove `SemanticFunctionConfig` ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves: #3173
Description
IPromptTemplateto namespaceMicrosoft.SemanticKernel.TemplateEnginePromptTemplateandPromptTemplateConfigto namespaceMicrosoft.SemanticKernel.TemplateEngineMicrosoft.SemanticKernel.SemanticFunctionsnamespaceSemanticFunctionConfigContribution Checklist