.Net: Simplify memory namespaces#4230
Merged
SergeyMenshykh merged 20 commits intomicrosoft:mainfrom Dec 13, 2023
Merged
Conversation
…o Microsoft.SemanticKernel.Memory namespace
shawncal
added
docs and tests
SergeyMenshykh
requested review from
dmytrostruk,
markwallace-microsoft and
rogerbarreto
…yMenshykh/semantic-kernel into simplify-memory-namespaces
markwallace-microsoft
approved these changes
Dec 13, 2023
alliscode
approved these changes
Dec 13, 2023
This was referenced Dec 14, 2023
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
Closes task `#1` of the issue - microsoft#3151 ### Description The `Memory` keyword is removed from the namespaces to make them slightly shorter and aligned with AI connector namespaces: - `Microsoft.SemanticKernel.Connectors.Memory.Chroma` -> `Microsoft.SemanticKernel.Connectors.Chroma` - `Microsoft.SemanticKernel.Connectors.Memory.AzureAISearch` -> `Microsoft.SemanticKernel.Connectors.AzureAISearch` - same for Kusto, Milvus, etc The `MemoryBuilder`, `VolatileMemoryStore` classes that live in the `Plugins.Memory` project under the `Microsoft.SemanticKernel.Plugins.Memory` namespace are moved to `Microsoft.SemanticKernel.Memory` namespace where they naturally belong to. --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes task
#1of the issue - #3151Description
The
Memorykeyword is removed from the namespaces to make them slightly shorter and aligned with AI connector namespaces:Microsoft.SemanticKernel.Connectors.Memory.Chroma->Microsoft.SemanticKernel.Connectors.ChromaMicrosoft.SemanticKernel.Connectors.Memory.AzureAISearch->Microsoft.SemanticKernel.Connectors.AzureAISearchThe
MemoryBuilder,VolatileMemoryStoreclasses that live in thePlugins.Memoryproject under theMicrosoft.SemanticKernel.Plugins.Memorynamespace are moved toMicrosoft.SemanticKernel.Memorynamespace where they naturally belong to.