Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: ChromaMemoryStore - Get methods will default to not return embeddings in query results #7563

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Python: ChromaMemoryStore - Get methods will default to not return embeddings in query results #7563

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea2a331
get methods will default to not return embeddings in query results
andrewldesousa Jul 30, 2024
709e954
get methods will default to not return embeddings in query results
andrewldesousa Jul 30, 2024
94c1924
Merge branch 'main' into chroma-with-embeddings-update
andrewldesousa Jul 30, 2024
ad74632
Merge branch 'main' into chroma-with-embeddings-update
andrewldesousa Jul 31, 2024
bd2f015
Merge branch 'main' into chroma-with-embeddings-update
andrewldesousa Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ async def upsert_batch(self, collection_name: str, records: list[MemoryRecord])
# upsert is checking collection existence
return [await self.upsert(collection_name, record) for record in records]

async def get(self, collection_name: str, key: str, with_embedding: bool) -> MemoryRecord:
async def get(self, collection_name: str, key: str, with_embedding: bool = False) -> MemoryRecord:
"""Gets a record.

Args:
Expand All @@ -200,7 +200,12 @@ async def get(self, collection_name: str, key: str, with_embedding: bool) -> Mem
f"Record with key '{key}' does not exist in collection '{collection_name}'"
) from exc

async def get_batch(self, collection_name: str, keys: list[str], with_embeddings: bool) -> list[MemoryRecord]:
async def get_batch(
self,
collection_name: str,
keys: list[str],
with_embeddings: bool = False
) -> list[MemoryRecord]:
"""Gets a batch of records.

Args:
Expand Down
Loading