V2 PagedResult fix #300
Merged
V2 PagedResult fix #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakunapamsft
requested review from
roshanroutray,
jyotimisramsft and
yashagarwal23
yashagarwal23
approved these changes
Jan 20, 2022
ameyanator
approved these changes
Jan 21, 2022
roshanroutray
approved these changes
Jan 24, 2022
roshanroutray
approved these changes
Jan 24, 2022
ameyanator
approved these changes
Jan 24, 2022
yashagarwal23
approved these changes
Jan 24, 2022
anantshankar17
approved these changes
Jan 25, 2022
pakunapamsft
added a commit
that referenced
this pull request
Feb 24, 2022
* LocalStoreConfigFix (#288) * Remove myget feed * Bumpup build version to consume latest bug fixes * Fix missing dependency upgrade * Check in runtimeconfig.dev.json exists (#289) .NET 6 doesn't create runtimeconfig.dev.json by default. See: dotnet/sdk#16818 * Bumpup build version to consume latest bug fixes * Modifying actor enumeration for KVS (#295) * Modifying actor enumeration for KVS * Addressing comments * Minor change to prevent additional loop during actor enumeration Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Bump up build version to consume latest bug fixes * Load KeyValueStore settings from settings.xml (#292) * Bumpup build version to consume latest fixes * Enumerate Reminders (#298) * Add GetRemindersAsync state provider api * Add GetReminders support in actor manager * Buf fixes * Bug fixes * Build fix * Enumerator dispose in KVS getactorsasync * Bumpup build version to consume latest fixes * V2 PagedResult fix (#300) * V2 PagedResult fix * Create ReminderPagedResult to serve GetRemindersAsync call * Bump up build version to consume latest bug fixes * Remoting exception serialization (#296) * Add Service convertors * Add client convertors * Fix build issues * Add actor convertors * Add FabricExceptionConvertor test * Add test cases * Add CustomConvertor Test * Add Compat tests * Fix test failures * Add telemetry * Minor fix * address comments Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> * Bump up build version to consume latest features * Fix regressions (#306) * Bump up build version to consume latest bug fixes Co-authored-by: sunil-indoria <sindoria@microsoft.com> Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> Co-authored-by: Preben Huybrechts <hpreben@gmail.com> Co-authored-by: jyotimisramsft <79437784+jyotimisramsft@users.noreply.github.com> Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com>
pakunapamsft
added a commit
that referenced
this pull request
Mar 3, 2022
* LocalStoreConfigFix (#288) * Remove myget feed * Bumpup build version to consume latest bug fixes * Fix missing dependency upgrade * Check in runtimeconfig.dev.json exists (#289) .NET 6 doesn't create runtimeconfig.dev.json by default. See: dotnet/sdk#16818 * Bumpup build version to consume latest bug fixes * Modifying actor enumeration for KVS (#295) * Modifying actor enumeration for KVS * Addressing comments * Minor change to prevent additional loop during actor enumeration Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Bump up build version to consume latest bug fixes * Load KeyValueStore settings from settings.xml (#292) * Bumpup build version to consume latest fixes * Enumerate Reminders (#298) * Add GetRemindersAsync state provider api * Add GetReminders support in actor manager * Buf fixes * Bug fixes * Build fix * Enumerator dispose in KVS getactorsasync * Bumpup build version to consume latest fixes * Add GetRemindersAsync implementation in KVStoRCMigrationActorStateProvider * Add Telemetry * Add Migration Settings * Refactor MigrationWorker framework * Fix Issues * Fix Issues * V2 PagedResult fix (#300) * V2 PagedResult fix * Create ReminderPagedResult to serve GetRemindersAsync call * Bump up build version to consume latest bug fixes * Refactor migration orchestrator * Remoting exception serialization (#296) * Add Service convertors * Add client convertors * Fix build issues * Add actor convertors * Add FabricExceptionConvertor test * Add test cases * Add CustomConvertor Test * Add Compat tests * Fix test failures * Add telemetry * Minor fix * address comments Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> * Bump up build version to consume latest features * temp commit * Refactor * Fix regressions (#306) * Bump up build version to consume latest bug fixes * Loosely couple migration * Return from RunAsync * Remove debug related code * Temp commit * Minor fixes * Add request forwarder * build fixes * Implement request forward checking * Fix actor events * Add comments * Add comments * Enable way to add Migration listener by custom actor service * Address comments Co-authored-by: sunil-indoria <sindoria@microsoft.com> Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> Co-authored-by: Preben Huybrechts <hpreben@gmail.com> Co-authored-by: jyotimisramsft <79437784+jyotimisramsft@users.noreply.github.com> Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com>
pakunapamsft
added a commit
that referenced
this pull request
Apr 1, 2022
* Migration state provider (#286) * Adding migration state provider * Adding reference to migration attribute * Minor change * Adding changes requested during PR * Adding warning logs while creating default state provider * Updating dictionaries used for saving KVS data in RC * Minor change in warning message Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Task 10222517: Milestone1: Enable KVS service to be migration ready (#287) * Add ActorMigrationAttribute * Added GrpcCommunicationListner * Initial changes to move to separate Actors.Migration library * add migrationwebendpoint generation to fabactutil * move to separate Actors.Migration library Part 2 * Add Actors.Migration Nuspec * Task 10222604: Check if Tombstonecleanup is disabled * Remove unnecessary package references * Implement Kestrel listner for ASP.NET core WebApi * Remove Grpc * Added Models * Clean up Debug code * Addressed review comments. Removed depndency on Microsoft.ServiceFabric.AspNetCore. Ported Kestrel communication listener code from Microsoft.ServiceFabric.AspNetCore library * moved dotnetframework to net461 for actors migration library * Adding migration worker framework and moving relevant changes to migration library (#290) * Migration worker framework * Moved relevant migration code to migration library Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Updating Migration Worker Framework (#293) * Migration worker framework * Moved relevant migration code to migration library * Read stream response from KVS API * Fixing formatting errors * Updating kvs enumerate API Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Fix Http endpoint resolve and request logic (#301) * Fix Http endpoint resolve and request logic * Fix http uri * Fix api paths (#302) * Rc migration web apis (#299) * Add RC migration Web APIs Reject all actor write calls when RejectWrites is set to true * Add RC migration Web APIs Reject all actor write calls when RejectWrites is set to true * Resolve build break after merge * Add ThrowIfMigrationInProgress(); * Added GetRejectWriteSate * Addressed review comments * Changes for making calls from rc to kvs (#303) Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Kvs rc config validation (#305) * Load KeyValueStore settings from settings.xml (#292) * Task 13072430: KVS - RC configuration validation Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> * Rebase to develop (#308) * LocalStoreConfigFix (#288) * Remove myget feed * Bumpup build version to consume latest bug fixes * Fix missing dependency upgrade * Check in runtimeconfig.dev.json exists (#289) .NET 6 doesn't create runtimeconfig.dev.json by default. See: dotnet/sdk#16818 * Bumpup build version to consume latest bug fixes * Modifying actor enumeration for KVS (#295) * Modifying actor enumeration for KVS * Addressing comments * Minor change to prevent additional loop during actor enumeration Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Bump up build version to consume latest bug fixes * Load KeyValueStore settings from settings.xml (#292) * Bumpup build version to consume latest fixes * Enumerate Reminders (#298) * Add GetRemindersAsync state provider api * Add GetReminders support in actor manager * Buf fixes * Bug fixes * Build fix * Enumerator dispose in KVS getactorsasync * Bumpup build version to consume latest fixes * V2 PagedResult fix (#300) * V2 PagedResult fix * Create ReminderPagedResult to serve GetRemindersAsync call * Bump up build version to consume latest bug fixes * Remoting exception serialization (#296) * Add Service convertors * Add client convertors * Fix build issues * Add actor convertors * Add FabricExceptionConvertor test * Add test cases * Add CustomConvertor Test * Add Compat tests * Fix test failures * Add telemetry * Minor fix * address comments Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> * Bump up build version to consume latest features * Fix regressions (#306) * Bump up build version to consume latest bug fixes Co-authored-by: sunil-indoria <sindoria@microsoft.com> Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> Co-authored-by: Preben Huybrechts <hpreben@gmail.com> Co-authored-by: jyotimisramsft <79437784+jyotimisramsft@users.noreply.github.com> Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * KVS to RC Actor state migration - Basic implementation (#304) * LocalStoreConfigFix (#288) * Remove myget feed * Bumpup build version to consume latest bug fixes * Fix missing dependency upgrade * Check in runtimeconfig.dev.json exists (#289) .NET 6 doesn't create runtimeconfig.dev.json by default. See: dotnet/sdk#16818 * Bumpup build version to consume latest bug fixes * Modifying actor enumeration for KVS (#295) * Modifying actor enumeration for KVS * Addressing comments * Minor change to prevent additional loop during actor enumeration Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Bump up build version to consume latest bug fixes * Load KeyValueStore settings from settings.xml (#292) * Bumpup build version to consume latest fixes * Enumerate Reminders (#298) * Add GetRemindersAsync state provider api * Add GetReminders support in actor manager * Buf fixes * Bug fixes * Build fix * Enumerator dispose in KVS getactorsasync * Bumpup build version to consume latest fixes * Add GetRemindersAsync implementation in KVStoRCMigrationActorStateProvider * Add Telemetry * Add Migration Settings * Refactor MigrationWorker framework * Fix Issues * Fix Issues * V2 PagedResult fix (#300) * V2 PagedResult fix * Create ReminderPagedResult to serve GetRemindersAsync call * Bump up build version to consume latest bug fixes * Refactor migration orchestrator * Remoting exception serialization (#296) * Add Service convertors * Add client convertors * Fix build issues * Add actor convertors * Add FabricExceptionConvertor test * Add test cases * Add CustomConvertor Test * Add Compat tests * Fix test failures * Add telemetry * Minor fix * address comments Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> * Bump up build version to consume latest features * temp commit * Refactor * Fix regressions (#306) * Bump up build version to consume latest bug fixes * Loosely couple migration * Return from RunAsync * Remove debug related code * Temp commit * Minor fixes * Add request forwarder * build fixes * Implement request forward checking * Fix actor events * Add comments * Add comments * Enable way to add Migration listener by custom actor service * Address comments Co-authored-by: sunil-indoria <sindoria@microsoft.com> Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> Co-authored-by: Preben Huybrechts <hpreben@gmail.com> Co-authored-by: jyotimisramsft <79437784+jyotimisramsft@users.noreply.github.com> Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Manual Migration (#311) * Pakunapa/kvs rc migration/exceptionhandling (#312) * Exception Handling * use constants * Fix NPE * Fix NPE on secondaries (#316) * Fix NPE on secondaries * Minor Fix * Bug fixes identified during E2E migration test (#318) * Changes for making calls from rc to kvs * KvsControllerBugFix * Enumerate kvs data bug fix Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> * Fix issues and enable winfab tests (#317) Co-authored-by: jyotimisramsft <79437784+jyotimisramsft@users.noreply.github.com> Co-authored-by: Jyoti Misra <jyotimisra@microsoft.com> Co-authored-by: Roshan Routray <11490554+roshanroutray@users.noreply.github.com> Co-authored-by: PavanKunapareddy <pavankumar.kunapareddy@gmail.com> Co-authored-by: sunil-indoria <sindoria@microsoft.com> Co-authored-by: Preben Huybrechts <hpreben@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.