Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching the version to Node20 is an unexpected breaking change released as a patch version. #125

Closed
cliffchapmanrbx opened this issue Jan 30, 2024 · 3 comments

Comments

@cliffchapmanrbx
Copy link

Hi team,

Version 1.3.2 of this action switched the required runtime from Node16 to Node20. This is a backwards-incompatible breaking change.

We use GitHub Enterprise Server on-prem which has a different release cadence and software support relationship with the GitHub Actions Runners. We have a number of complex builds that we're working on migrating to Node20.

As Node20 changes runner requirements most GitHub Actions have chosen to release a major version bump. The unexpected patch version change caused us some headaches as we ran around fixing things.

Would it be possible to release a revert for the v1 action, and publish a separate v2 version with the Node20 change?

@timheuer
Copy link
Member

Hi @cliffchapmanrbx thanks for this. Apologies for unintended impact of this. In hindsight I should have known not to patch.

Interim is that v1.3.1 should unblock you for now.

Your request is reasonable and I’ll take that action.

@cliffchapmanrbx
Copy link
Author

Interim is that v1.3.1 should unblock you for now.

Yep we've been updating our workflow files to pin the working version as a workaround, it's just a lot of effort across our codebases :)

Your request is reasonable and I’ll take that action.

Thank you very much for the quick response! We've gotten a lot of mileage out of this action and appreciate it continuing to be supported.

@timheuer
Copy link
Member

Thanks again @cliffchapmanrbx for raising the concern. The following action was taken:

v1.3.3 created (and v1 and v1.1 tags updated) to revert back to node16
v2 (v2.0.0) created with the node20 change and no other functionality changes

I apologize for this oversight of not being mindful of the potential impact in even a minor change (let alone patch version).

dougwaldron added a commit to gaepdit/iaip that referenced this issue Feb 22, 2024
dougwaldron added a commit to gaepdit/iaip that referenced this issue Feb 22, 2024
* Bump microsoft/setup-msbuild from 1.1 to 1.3

Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.1 to 1.3.
- [Release notes](https://github.com/microsoft/setup-msbuild/releases)
- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)
- [Commits](microsoft/setup-msbuild@v1.1...v1.3)

---
updated-dependencies:
- dependency-name: microsoft/setup-msbuild
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump microsoft/setup-msbuild from 1.3 to 2

v1.3 does not update the Node version. See microsoft/setup-msbuild#125

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Doug Waldron <douglas.waldron@dnr.ga.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants