Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizeclass rounding error #209

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Fix sizeclass rounding error #209

merged 1 commit into from
Jun 8, 2020

Conversation

Theodus
Copy link
Contributor

@Theodus Theodus commented Jun 6, 2020

No description provided.

Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Could you change the < to use = round_size(size)

if (asize < size)

Then this failure would have been caught.

Also would sooner not have the reformatting as part of this.

@Theodus Theodus requested a review from mjp41 June 6, 2020 15:53
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. I'll run some performance experiments on this on Monday to see if this is why our realloc performance was bad compared to mimalloc.

@mjp41 mjp41 merged commit 61afa77 into microsoft:master Jun 8, 2020
@mjp41 mjp41 mentioned this pull request Jun 8, 2020
@mjp41
Copy link
Member

mjp41 commented Jun 8, 2020

@aganea, FYI this might have negatively impacted your LLD results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants