Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown #522

Merged
merged 3 commits into from
May 10, 2022
Merged

Fix markdown #522

merged 3 commits into from
May 10, 2022

Conversation

panekj
Copy link
Contributor

@panekj panekj commented May 10, 2022

No description provided.

Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing

@ghost
Copy link

ghost commented May 10, 2022

CLA assistant check
All CLA requirements met.

@panekj

This comment was marked as outdated.

@panekj
Copy link
Contributor Author

panekj commented May 10, 2022

There is missing use of [^mmu-perms] in StrictProvenance.md

@panekj panekj changed the title Fix markdown link to ./docs/AddressSpace Fix markdown May 10, 2022
Copy link
Collaborator

@nwf nwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix; the missing mmu-perms note looks to have always been detached (oops!). It should probably go at the end of the sentence "Borrowing terminology from CHERI, we speak of the authority (to a subset of the address space) held by a pointer and will justify actions in terms of this authority.". If you want to add that, feel free, otherwise I'll track it locally and roll it into a later PR.

@mjp41 mjp41 merged commit c4f31bb into microsoft:main May 10, 2022
@panekj panekj deleted the patch-1 branch May 10, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants