Haiku build fix post refactoring. #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
haiku_build_fix3
branch
from
5b00261 to
c381de6
Compare
mjp41
approved these changes
May 25, 2022
src/snmalloc/pal/pal_haiku.h
Outdated
| * Hopefully a temporary workaround until the kernel random feature | ||
| * is exposed properly in the userspace ? | ||
| */ | ||
|
|
There was a problem hiding this comment.
Extraneous new line.
Suggested change
devnexen
force-pushed
the
haiku_build_fix3
branch
from
c381de6 to
e689494
Compare
|
|
||
| /** | ||
| * Hopefully a temporary workaround until the kernel random feature | ||
| * is exposed properly in the userspace ? |
There was a problem hiding this comment.
Is there a Haiku bug that is tracking this? If so, it would be great to link to it in the comment so that the next person to revisit this can easily see if it's still needed.
There was a problem hiding this comment.
there is none I just read the os source code and see some good promises regarding this but haiku is still in beta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.