Pagemap Rounding #558
Merged
Pagemap Rounding #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf-msr
suggested changes
Sep 16, 2022
| auto end = pointer_align_down( | ||
| // Calculate range in pagemap that is associated to this space. | ||
| // Over calculate to cover any unaligned parts at either end. | ||
| auto b_align = pointer_align_down(b, bits::one_at_bit(GRANULARITY_BITS)); |
There was a problem hiding this comment.
While this might take b_align below b, and so logically start our PageMap out of bounds, that's OK because we never access the MetaEntry-s associated with the PageMap itself?
There was a problem hiding this comment.
Is b_align only used in address and size computations? If yes, then would it be clearer and safer to get the address of b and align the address down? That way no wild pointer exists.
There was a problem hiding this comment.
So I have tried to make this capability less code as it is just addresses like you suggest:
9542fbe
ihaller
reviewed
Sep 16, 2022
|
I am very happy with this change now. |
Check for possible overlap between heap and pagemap, but writing and reading the heap.
This commit allows the pagemap to return unaligned range of memory. This means that bump allocation of multiple pagemaps doesn't waste as much space.
mjp41
force-pushed
the
pagemaprounding
branch
from
9542fbe to
bcfd5ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that if a pagemap is used in a fixed region that has very large granularity it does require undue additional alignment.