Various changes to improve startup times for lots of threads #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf-msr
suggested changes
Nov 3, 2022
mjp41
force-pushed
the
startup
branch
3 times, most recently
from
a409040 to
1c8902d
Compare
|
I have dropped the changes to the Pool implementation as they seemed to be hitting a miscompilation on CHERI. |
nwf
requested changes
Nov 4, 2022
The buddy allocator doesn't need to look at sizes above the current highest size. This commit tracks the highest block that is stored in the buddy allocator.
Round meta-data up to large size This change means we don't have to madvise/commit memory holding a lock. This was showing up in profiles of with high-thread counts on very short workloads.
Rather than allocating a sizeclass use a stub. This change adds a branch on enqueue.
This was referenced Mar 23, 2023
Merged
|
I am closing this in favour of a few smaller PR with defined changes. It is not clear the MCS queue lock or the changes to the metadata in this PR make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling starting a lot of threads, I found a few bits that could be improved. This PR attempts to reduce the contention on startup. By
Removing a lock from the pool implementation