fatal error making less C for C++20. #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
report_error_cxx20
branch
from
942a0e5 to
f21d165
Compare
devnexen
force-pushed
the
report_error_cxx20
branch
from
f21d165 to
b9633db
Compare
|
The version check added in this PR is incorrect and is causing breakage with clang 15. The It's also incredibly fragile to assume that compiler version implies C++ standard library version. C++ has a standard mechanism for checking these features. We should do: #ifdef __cpp_lib_source_locationWe might also want to check that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.