Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch CI up with github #577

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Catch CI up with github #577

merged 4 commits into from
Dec 13, 2022

Conversation

nwf-msr
Copy link
Contributor

@nwf-msr nwf-msr commented Dec 12, 2022

@nwf-msr nwf-msr requested a review from mjp41 December 12, 2022 13:49
@nwf-msr nwf-msr mentioned this pull request Dec 12, 2022
Merged
mjp41
mjp41 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If it not to much trouble, could you add a comment about why we aren't using latest. I guess we could evolve some tests to a later clang?

@nwf-msr
Copy link
Contributor Author

nwf-msr commented Dec 12, 2022

No trouble at all. If you want to pick a clang version to switch to, or to add in addition to the ubuntu-20.04/clang-10 mix, I'm happy to add those too.

@nwf-msr
Copy link
Contributor Author

nwf-msr commented Dec 12, 2022

Don't merge; testing newer clangs. If it works, I'll expand some commentary and then we can merge.

@nwf-msr
Move std::atomic_flag to std::atomic<bool>
92b3779 
C++20 accidentally deprecated ATOMIC_FLAG_INIT, but in C++17 this is the
only way to reliably initialize an atomic_flag to a known value.
See https://en.cppreference.com/w/cpp/atomic/ATOMIC_FLAG_INIT
@nwf-msr
CI: Further fallout from ubuntu 22.04
6260584 
- Copy and shift our clang-10-specific variant tests onto the latest

- Additionally add 20.04 as a test point, along-side 18.04
@nwf-msr
Copy link
Contributor Author

nwf-msr commented Dec 13, 2022

OK, maybe ready now. :)

mjp41
mjp41 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@nwf-msr nwf-msr merged commit 455cdd8 into microsoft:main Dec 13, 2022
@nwf-msr nwf-msr deleted the 202212-ubuntu branch December 13, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjp41 mjp41 mjp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwf-msr @mjp41