-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Microsoft.Data.SqlClient to v5.0.1 #1708
Conversation
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/Parser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Kusto.ServiceLayer/Microsoft.Kusto.ServiceLayer.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/ExecutionEngineCode/BatchParserSqlCmd.cs
Outdated
Show resolved
Hide resolved
...Microsoft.SqlTools.ManagedBatchParser/BatchParser/ExecutionEngineCode/ScriptExecutionArgs.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Microsoft.SqlTools.ServiceLayer.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Connection/ReliableConnectionTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.Test.Common/TestConnectionProfileService.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/ExecutionEngineCode/BatchParserSqlCmd.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…nEngineCode/BatchParserSqlCmd.cs
19580ca
to
83fdaa2
Compare
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
Brings in all necessary changes to update Microsoft.Data.SqlClient to v5.0.1.
❗Breaking changes❗
Microsoft.SqlTools.ManagedBatchParser
now targets .NET 6 and .Net Framework 4.7.2 (earlier .NET Standard 2.0). Since DacFx also targets .NET Standard 2.1, STS can no longer build for .NET Standard 2.0. MSBuild was picking .NET Framework DLLs from DacFx for .NET Standard 2.0 build.ConnectionDetails.Encrypt
is now astring
(previously bool) - backwards compatible with ADS Connection Options'Optional', 'Mandatory', 'Strict', 'True', 'False', 'Yes', 'No'
New:
ConnectionDetails
property:HostNameInCertificate: string
to align withSqlConnection
properties.Todo (will do in another PR):