Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Data.SqlClient to v5.0.1 #1708

Merged
merged 28 commits into from
Oct 25, 2022
Merged

Update Microsoft.Data.SqlClient to v5.0.1 #1708

merged 28 commits into from
Oct 25, 2022

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Sep 23, 2022

Brings in all necessary changes to update Microsoft.Data.SqlClient to v5.0.1.

Breaking changes

  • Microsoft.SqlTools.ManagedBatchParser now targets .NET 6 and .Net Framework 4.7.2 (earlier .NET Standard 2.0). Since DacFx also targets .NET Standard 2.1, STS can no longer build for .NET Standard 2.0. MSBuild was picking .NET Framework DLLs from DacFx for .NET Standard 2.0 build.
  • ConnectionDetails.Encrypt is now a string (previously bool) - backwards compatible with ADS Connection Options
    • Accepted values: 'Optional', 'Mandatory', 'Strict', 'True', 'False', 'Yes', 'No'

New:

  • Adds new ConnectionDetails property: HostNameInCertificate: string to align with SqlConnection properties.

Todo (will do in another PR):

  • Update DacFx NuGet to contain HostNameInCertificate support [Waiting]
    • Failures captured in DacFx Service tests when HostNameInCertificate is required to be provided.

@github-actions
Copy link

github-actions bot commented Sep 23, 2022

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms (Windows/Mac/Linux)
  • Check the source repo for any open issues with the release being updated to (if available)

@github-actions
Copy link

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms (Windows/Mac/Linux)
  • Check the source repo for any open issues with the release being updated to (if available)

@cheenamalhotra cheenamalhotra changed the title Update Microsoft.Data.SqlClient to v5.0.0 Update Microsoft.Data.SqlClient to v5.0.1 Oct 14, 2022
@cheenamalhotra cheenamalhotra marked this pull request as ready for review October 18, 2022 15:18
Copy link
Contributor

@Matteo-T Matteo-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Contributor

@Matteo-T Matteo-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

@cheenamalhotra cheenamalhotra marked this pull request as ready for review October 25, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants