uncomment tasks that use backup secrets #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjin
approved these changes
Jun 12, 2024
| azureSubscription: 'STS Pipelines' # this is the name of the service connection, which be found in mssqltools/CrossPlatBuildScripts ADO under Project Settings -> Service Connections | ||
| KeyVaultName: SqlToolsSecretStore | ||
| SecretsFilter: 'sqltools-backup-url-tests-blobcontaineruri,sqltools-backup-url-tests-storageaccountname,sqltools-backup-url-tests-storageaccountkey' | ||
| # Uncomment tasks that use secrets while we get context on managed identity |
There was a problem hiding this comment.
Technically, you're commenting them out, not uncommenting them!
Benjin
approved these changes
Jun 12, 2024
| KeyVaultName: SqlToolsSecretStore | ||
| SecretsFilter: 'sqltools-backup-url-tests-blobcontaineruri,sqltools-backup-url-tests-storageaccountname,sqltools-backup-url-tests-storageaccountkey' | ||
| # Uncomment tasks that use secrets while we get context on managed identity | ||
| # - task: AzureKeyVault@1 |
There was a problem hiding this comment.
Actually, let's completely delete this AzureKeyVault@1 step instead of just commenting it out. But still leave the "Running integration tests" step below commented-out (instead of deleted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.