Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing incorrect "attachedDBFileName" option #2408

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Removing incorrect "attachedDBFileName" option #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionProviderOptionsHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,6 @@ internal static ConnectionProviderOptions BuildConnectionProviderOptions()
ValueType = ConnectionOption.ValueTypeString,
},
new ConnectionOption
{
Name = "attachedDBFileName",
DisplayName = SR.ConnectionConfigOptions_attachedDBFileName_displayName,
Description = SR.ConnectionConfigOptions_attachedDBFileName_description,
ValueType = ConnectionOption.ValueTypeString,
GroupName = SR.ConnectionConfigOptions_groups_context
},
new ConnectionOption
{
Name = "contextConnection",
DisplayName = SR.ConnectionConfigOptions_contextConnection_displayName,
Expand Down Expand Up @@ -292,7 +284,7 @@ internal static ConnectionProviderOptions BuildConnectionProviderOptions()
Name = "attachDbFilename",
DisplayName = SR.ConnectionConfigOptions_attachDbFilename_displayName,
ValueType = ConnectionOption.ValueTypeString,
GroupName = "Source"
GroupName = SR.ConnectionConfigOptions_groups_context
},
new ConnectionOption
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5506,7 +5506,7 @@ The Query Processor estimates that implementing the following index could improv
<comment></comment>
</data>
<data name="ConnectionConfigOptions_connectTimeout_displayName" xml:space="preserve">
<value>Connect timeout</value>
<value>Connection timeout (seconds)</value>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some loc changes that missed the last PR

<comment></comment>
</data>
<data name="ConnectionConfigOptions_connectTimeout_description" xml:space="preserve">
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@
<note></note>
</trans-unit>
<trans-unit id="ConnectionConfigOptions_connectTimeout_displayName">
<source>Connect timeout</source>
<target state="new">Connect timeout</target>
<source>Connection timeout (seconds)</source>
<target state="new">Connection timeout (seconds)</target>
<note></note>
</trans-unit>
<trans-unit id="ConnectionConfigOptions_commandTimeout_displayName">
Expand Down