Fix error handling in SimpleExecuteRequest to return actual SQL error messages #2536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two bugs in
HandleSimpleExecuteRequest:SQL error messages not returned: Queries with SQL errors (e.g., invalid table names) returned generic "Query has no results to return" instead of actual error details. Fixed by collecting error messages via
BatchMessageSentevents and checkingbatch.HasErrorin the completion callback.Queries without result sets treated as errors: Valid DML/DDL statements (UPDATE, DELETE, CREATE TABLE) incorrectly returned errors. Fixed by returning success with empty result arrays when
resultSets.Count == 0.What these two fixes look like for query execution in GHCP:
Code Changes Checklist
dotnet test)Reviewers: Please read our reviewer guidelines