-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix small issues in the integration of Graph2Edits (#66)
The recent integration of Graph2Edits in #65 missed two caveats: - The `syntheseus-graph2edits` package did not specify that it depends on `joblib`, which was missed in initial testing as it's a rather common dependency that is pulled in by e.g. LocalRetro, so this issue only arises when Graph2Edits is used in isolation. I pushed version `0.2.0` that specifies the dependency and in this PR I bump the version requirement in syntheseus. - In very rare cases (e.g. for the molecule with SMILES "OBr"), the Graph2Edits code fails with an unclear `IndexError`. This was not seen during evaluation on USPTO-50K, but happens occasionally during search. As these cases are very rare and there is no obvious fix, I resort to simply catching the exception and returning no proposed reactions in this case.
- Loading branch information
Showing
3 changed files
with
11 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters