Get all models to work on CPU #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinT
approved these changes
Jan 10, 2024
kmaziarz
added a commit
that referenced
this pull request
Jan 11, 2024
kmaziarz
added a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #48 added a new CI pipeline that covers single-step model inference, but it only tested half of the single-step models as the other ones did not work on CPU. This PR fixes this, making all models work on CPU, which mostly required making sure the right device is correctly propagated into all of the model internals. I then extended the test which now checks all
pip-installable models we support.Additionally, I also merged the two CI pipelines into one, as this allows for generating a combined coverage report that takes into account all tests. This does not affect testing speed, as the different test jobs still run in parallel. Finally, I also noticed that the
.coveragercconfiguration was not quite right, as the files with 0% coverage were not being discovered (e.g. see this CI run onmainwhich did not report the 0% coverage ofcli/search.py); after a minor change to the configuration this is now fixed (see here).The changes are separated into self-contained commits for easier reviewing.