-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
... this takes care of the current command also appearing in the history
- Loading branch information
1 parent
b85eb30
commit 0907c50
Showing
2 changed files
with
16 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2246,19 +2246,28 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |
return winrt::hstring{ L"" }; | ||
}; | ||
|
||
const auto currentCommand = _terminal->CurrentCommand(); | ||
const auto trimmedCurrentCommand = trimToHstring(currentCommand); | ||
|
||
for (const auto& commandInBuffer : bufferCommands) | ||
{ | ||
if (const auto hstr {trimToHstring(commandInBuffer)} ; !hstr.empty() ) | ||
if (const auto hstr{ trimToHstring(commandInBuffer) }; | ||
(!hstr.empty() && hstr != trimmedCurrentCommand)) | ||
{ | ||
commands.push_back(hstr); | ||
} | ||
} | ||
|
||
auto context = winrt::make_self<CommandHistoryContext>(std::move(commands)); | ||
|
||
const auto currentCommand = _terminal->CurrentCommand(); | ||
context->CurrentCommandline(trimToHstring(currentCommand)); | ||
// If the very last thing in the list of recent commands, is exacly the | ||
Check failure Code scanning / check-spelling Unrecognized Spelling Error
exacly is not a recognized word. (unrecognized-spelling)
|
||
// same as the current command, then let's not include it in the | ||
// history. It's literally the thing the user has typed, RIGHT now. | ||
if (commands.back() == trimmedCurrentCommand) | ||
{ | ||
commands.pop_back(); | ||
} | ||
|
||
auto context = winrt::make_self<CommandHistoryContext>(std::move(commands)); | ||
context->CurrentCommandline(trimmedCurrentCommand); | ||
return *context; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0907c50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@check-spelling-bot Report
🔴 Please review
See the 📜action log or 📝 job summary for details.
Unrecognized words (1)
exacly
Previously acknowledged words that are now absent
CRLFs Redir wcsicmp 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands
... in a clone of the git@github.com:microsoft/terminal.git repository
on the
dev/migrie/b/17241-sxnui-trailing
branch (ℹ️ how do I use this?):Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary
This includes both expected items (2207) from .github/actions/spelling/expect/04cdb9b77d6827c0202f51acd4205b017015bfff.txt
.github/actions/spelling/expect/alphabet.txt
.github/actions/spelling/expect/expect.txt
.github/actions/spelling/expect/web.txt and unrecognized words (1)
Consider adding them (in
.github/workflows/spelling2.yml
) foruses: check-spelling/check-spelling@v0.0.22
in itswith
:To stop checking additional dictionaries, add (in
.github/workflows/spelling2.yml
) foruses: check-spelling/check-spelling@v0.0.22
in itswith
:Errors (1)
See the 📜action log or 📝 job summary for details.
See ❌ Event descriptions for more information.
✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
.github/actions/spelling/allow/names.txt
..github/actions/spelling/allow/
..github/actions/spelling/expect/
..github/actions/spelling/patterns/
.See the
README.md
in each directory for more information.🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txt
file matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^
refers to the file's path from the root of the repository, so^README\.md$
would exclude README.md (on whichever branch you're using).well-formed pattern.
If you can write a pattern that would match it,
try adding it to the
patterns.txt
file.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.