ALSO doesn't really need to be projected

microsoft · Mar 26, 2024 · 10e1e46 · 10e1e46
1 parent ddc88c8
commit 10e1e46
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 13 deletions.
diff --git a/src/cascadia/TerminalApp/SettingsPaneContent.cpp b/src/cascadia/TerminalApp/SettingsPaneContent.cpp
@@ -3,7 +3,6 @@
 
 #include "pch.h"
 #include "SettingsPaneContent.h"
-#include "SettingsPaneContent.g.cpp"
 #include "Utils.h"
 
 using namespace winrt::Windows::Foundation;

diff --git a/src/cascadia/TerminalApp/SettingsPaneContent.h b/src/cascadia/TerminalApp/SettingsPaneContent.h
@@ -2,13 +2,14 @@
 // Licensed under the MIT license.
 
 #pragma once
-#include "SettingsPaneContent.g.h"
+#include "winrt/TerminalApp.h"
 #include <LibraryResources.h>
 
 namespace winrt::TerminalApp::implementation
 {
-    struct SettingsPaneContent : SettingsPaneContentT<SettingsPaneContent>
+    class SettingsPaneContent : public winrt::implements<SettingsPaneContent, IPaneContent>
     {
+    public:
         SettingsPaneContent(winrt::Microsoft::Terminal::Settings::Model::CascadiaSettings settings);
 
         void UpdateSettings(const winrt::Microsoft::Terminal::Settings::Model::CascadiaSettings& settings);
@@ -43,8 +44,3 @@ namespace winrt::TerminalApp::implementation
         winrt::Windows::UI::Xaml::ElementTheme _requestedTheme;
     };
 }
-
-namespace winrt::TerminalApp::factory_implementation
-{
-    BASIC_FACTORY(SettingsPaneContent);
-}
diff --git a/src/cascadia/TerminalApp/TerminalPaneContent.idl b/src/cascadia/TerminalApp/TerminalPaneContent.idl
@@ -18,9 +18,4 @@ namespace TerminalApp
 
         event Windows.Foundation.TypedEventHandler<TerminalPaneContent, Object> RestartTerminalRequested;
     }
-
-    [default_interface] runtimeclass SettingsPaneContent : IPaneContent
-    {
-        SettingsPaneContent(Microsoft.Terminal.Settings.Model.CascadiaSettings settings);
-    }
 }
diff --git a/src/cascadia/TerminalApp/TerminalTab.cpp b/src/cascadia/TerminalApp/TerminalTab.cpp
@@ -5,6 +5,7 @@
 #include <LibraryResources.h>
 #include "ColorPickupFlyout.h"
 #include "TerminalTab.h"
+#include "SettingsPaneContent.h"
 #include "TerminalTab.g.cpp"
 #include "Utils.h"
 #include "ColorHelper.h"