-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Warn when using old MacType versions (#17369)
This adds a check for whether MacType is injected and whether it's a known bad version (pre-2023). In that case we avoid calling the known faulty `ID2D1Device4` interface. We could avoid it in general to fix the issue without a warning (it's only a very mild optimization), but on the other hand, the bug that MacType has is a very serious one and it's probably better overall to suggest users to update. See: snowie2000/mactype#938 ## Validation Steps Performed * MacType 2021.1-RC1 results in a warning and no crash ✅ * MacType 2023.5.31 results in no warning ✅ --------- Co-authored-by: Dustin L. Howett <duhowett@microsoft.com> (cherry picked from commit 9317d42) Service-Card-Id: 92687129 Service-Version: 1.21
- Loading branch information
Showing
5 changed files
with
80 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters