CharRow: remove UpdateParent -- we never re-seat CharRows

microsoft · Nov 25, 2020 · d226521 · d226521
1 parent 331fe14
commit d226521
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/src/buffer/out/CharRow.cpp b/src/buffer/out/CharRow.cpp
@@ -267,12 +267,3 @@ COORD CharRow::GetStorageKey(const size_t column) const noexcept
 {
     return { gsl::narrow<SHORT>(column), _pParent->GetId() };
 }
-
-// Routine Description:
-// - Updates the pointer to the parent row (which might change if we shuffle the rows around)
-// Arguments:
-// - pParent - Pointer to the parent row
-void CharRow::UpdateParent(ROW* const pParent)
-{
-    _pParent = FAIL_FAST_IF_NULL(pParent);
-}
diff --git a/src/buffer/out/CharRow.hpp b/src/buffer/out/CharRow.hpp
@@ -83,8 +83,6 @@ class CharRow final
     const UnicodeStorage& GetUnicodeStorage() const noexcept;
     COORD GetStorageKey(const size_t column) const noexcept;
 
-    void UpdateParent(ROW* const pParent);
-
     friend CharRowCellReference;
     friend bool operator==(const CharRow& a, const CharRow& b) noexcept;
     friend class ROW;

diff --git a/src/buffer/out/textBuffer.cpp b/src/buffer/out/textBuffer.cpp
@@ -901,9 +901,6 @@ void TextBuffer::_RefreshRowIDs(std::optional<SHORT> newRowWidth)
         // Update the IDs
         it.SetId(i++);
 
-        // Also update the char row parent pointers as they can get shuffled up in the rotates.
-        it.GetCharRow().UpdateParent(&it);
-
         // Resize the rows in the X dimension if we have a new width
         if (newRowWidth.has_value())
         {