Skip to content

Commit

Permalink
Fix the 'RunMakeKillTabs' PGO test (#13089)
Browse files Browse the repository at this point in the history
## Summary of the Pull Request
For some reason, the PGO tests (specifically the `RunMakeKillTabs` test) started to fail after #12979 merged. After closer inspection, the test was actually improperly written. We should be using <kbd>ctrl+shift+t</kbd> to open new tabs, not <kbd>alt+shift+t</kbd>. Presumably, the <kbd>alt</kbd> was copied over from the previous test, because they look _very_ similar.

So I went ahead and fixed the test, and it now (1) tests what it's intended to test and (2) doesn't fail. Why did #12979 cause the tests to fail? idk, but it works now.

## References
#10071 - Introduce PGO Tests

## Validation Steps Performed
Ran PGO tests locally and confirmed that it works.
Ran PGO pipeline and confirmed that it works.

(cherry picked from commit 17d1e24)
Service-Card-Id: 81863976
Service-Version: 1.14
  • Loading branch information
carlos-zamora committed May 12, 2022
1 parent 521d968 commit eb40b51
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/cascadia/WindowsTerminal_UIATests/SmokeTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,13 @@ public void RunMakeKillTabs()
{
var root = app.GetRoot();

root.SendKeys(Keys.LeftAlt + Keys.LeftShift + "T");
root.SendKeys(Keys.LeftControl + Keys.LeftShift + "T");
Globals.WaitForTimeout();
root.SendKeys(Keys.LeftAlt + Keys.LeftShift + "T");
root.SendKeys(Keys.LeftControl + Keys.LeftShift + "T");
Globals.WaitForTimeout();
root.SendKeys(Keys.LeftAlt + Keys.LeftShift + "T");
root.SendKeys(Keys.LeftControl + Keys.LeftShift + "T");
Globals.WaitForTimeout();
root.SendKeys(Keys.LeftAlt + Keys.LeftShift + "T");
root.SendKeys(Keys.LeftControl + Keys.LeftShift + "T");
Globals.WaitForTimeout();
root.SendKeys(Keys.LeftControl + Keys.LeftShift + "W");
Globals.WaitForTimeout();
Expand Down

0 comments on commit eb40b51

Please sign in to comment.