Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping text in Command Palette submenu after deleting ">" #10140

Closed
KalleOlaviNiemitalo opened this issue May 20, 2021 · 4 comments · Fixed by #10164
Closed

Overlapping text in Command Palette submenu after deleting ">" #10140

KalleOlaviNiemitalo opened this issue May 20, 2021 · 4 comments · Fixed by #10164
Labels
Area-CmdPal Command Palette issues and features Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented May 20, 2021 •
edited
Loading

Windows Terminal version (or Windows build number)

1.7.1033.0

Other Software

No response

Steps to reproduce

  1. Press Ctrl+Shift+P. The Command Palette opens.
  2. Scroll to the "Select color scheme…" item and click that. The Command Palette displays a list of color schemes.
  3. Press Backspace. The list of color schemes disappears, but the "Select color scheme…" title is still visible.
  4. Type cmd. Do not press Enter.

Expected Behavior

It should tell me what will happen if I press Enter.

Executing command line will invoke the following commands:
New tab, commandline: cmd

Actual Behavior

The dim "Select color scheme…" title overlaps the description of the command line.

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 20, 2021
@KalleOlaviNiemitalo
Copy link
Author

Found while trying #7910.

@zadjii-msft
Copy link
Member

Ooh, good point. I see two options:

  • disable backspacing the > in a nested entry.
  • Entering commandline mode in a nested entry should pop the nested entries stack. That should get rid of the "< Select color scheme..." element.

@zadjii-msft zadjii-msft added Area-CmdPal Command Palette issues and features Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels May 20, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 20, 2021
@zadjii-msft zadjii-msft mentioned this issue May 20, 2021
Open
52 tasks
@kovdu kovdu mentioned this issue May 24, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label May 24, 2021
@ghost ghost closed this as completed in #10164 May 24, 2021
ghost pushed a commit that referenced this issue May 24, 2021
@kovdu
Clear all state tracking nested commands when switching command mode (#…
dd348dc 
…10164)

Went for option 2 proposed here:
#10140 (comment). 

Disabling back space in the nested entry didn't felt as the nicest
solution.  Instead now all state that keeps track of nested commands is
cleared when switching beteen modes.

## Validation Steps Performed
- Validated the specified issue is fixed by this change:. now after
  entering a sub command and hitting backspace the palette no longer
  shows the sub command item (here `< Select color scheme...` ).
- Validated that switching between all modes (command line, actions, tab
  search & tab switch) still work as expected.
- Validated as well that all modes still work as expected.

Didn't add unit tests, but happy to try that out if this would be
required. 

Closes #10140
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 24, 2021
DHowett pushed a commit that referenced this issue May 24, 2021
@kovdu @DHowett
Clear all state tracking nested commands when switching command mode (#…
afd6a87 
…10164)

Went for option 2 proposed here:
#10140 (comment).

Disabling back space in the nested entry didn't felt as the nicest
solution.  Instead now all state that keeps track of nested commands is
cleared when switching beteen modes.

## Validation Steps Performed
- Validated the specified issue is fixed by this change:. now after
  entering a sub command and hitting backspace the palette no longer
  shows the sub command item (here `< Select color scheme...` ).
- Validated that switching between all modes (command line, actions, tab
  search & tab switch) still work as expected.
- Validated as well that all modes still work as expected.

Didn't add unit tests, but happy to try that out if this would be
required.

Closes #10140

(cherry picked from commit dd348dc)
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #10164, which has now been successfully released as Windows Terminal v1.8.1444.0.:tada:

Handy links:

@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #10164, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CmdPal Command Palette issues and features Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Clear all state tracking nested commands when switching command mode kovdu/terminal
2 participants
@zadjii-msft @KalleOlaviNiemitalo