-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quake Mode multi monitor setup #10274
Comments
In my case, I got two monitors. On first I have no Windows taskbar, on second I got Windows taskbar located at right monitor edge. When I run Quake mode on monitor 2 it is looking ok: But when I do Quake mode on monitor 1, Windows Terminal is having gap in place where the Windows taskbar is on second monitor: |
I've been having some issues with the quake mode on multi monitors. (love this new feature btw).. My setup is a 4k landscape monitor above the laptop and a hd portrait monitor next to the that. All 3 monitors have different resolutions and scaling factors. When opening on the laptop screen it works perfectly, full width of the screen. Sometimes it gets confused and doesn't know which is the active screen and opens in the previous window, other times it opens in random places on the screen (usually the middle) There is also what feels like screen tear in the slide down effect. Hope this helps in getting the bugs ironed out. If needed, I can provide screenshots. Brent |
Welp, that's weird. I've been using QM for a while with multi-mon, but never ran into anything like this. Maybe the vertical/horizontal orientation is important here. I'll stick this on 2.0 for now, but if anyone who's actually hitting this could help debug, that'd definitely be appreciated. |
notes before I leave for the weekend:
|
…tor (#10674) ## Summary of the Pull Request When the quake window is moved to another monitor, re-evaluate it's size for that monitor. ## References * megathread: #8888 * Similar, but not the same: #10274 ## PR Checklist * [x] Closes #10182 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews. ## Validation Steps Performed Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does.
IM having a similar issue. I have horizontal screens layout but they're different resolutions and scaling. My secondary screen is 4k@150% scaling and my primary screen is 1440p. When the terminal opens on the secondary screen it doesn't go all the way across. PS - Also really appreciate this quake console mode. I was doing it manually with AHK and then it wasn't working properly one day and realized you guys baked the feature in using the same hotkey 😅 |
## Summary of the Pull Request <kbd>win+shift+arrows</kbd> can be used to move windows to adjacent monitors. When that happens, we'll new re-calculate the size of the window for the new monitor. ## References * megathread: #8888 ## PR Checklist * [x] Closes #10274 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments In `WM_WINDOWPOSCHANGING`, the OS says "hey, I'm about to do {something} to your window. You cool with that?". We handle that message by: 1. checking if the window was _moved_ as a part of this message 2. getting the monitor that the window will be moved onto 3. If that monitor is different than the monitor the window is currently on, then * calculate how big the quake window should be on that monitor * tell the OS that's where we'd like to be. ## Validation Steps Performed * <kbd>win+shift+arrows</kbd> works right now * normal quake summoning still works right
Actually, is there any way to just turn this off? I want my own implementation back and WT won't let me use this keyboard shortcut for my AHK script anymore. I thought it was cool but Quake mode is a hindrance I want it gone. |
…tor (#10674) ## Summary of the Pull Request When the quake window is moved to another monitor, re-evaluate it's size for that monitor. ## References * megathread: #8888 * Similar, but not the same: #10274 ## PR Checklist * [x] Closes #10182 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews. ## Validation Steps Performed Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does.
## Summary of the Pull Request <kbd>win+shift+arrows</kbd> can be used to move windows to adjacent monitors. When that happens, we'll new re-calculate the size of the window for the new monitor. ## References * megathread: #8888 ## PR Checklist * [x] Closes #10274 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments In `WM_WINDOWPOSCHANGING`, the OS says "hey, I'm about to do {something} to your window. You cool with that?". We handle that message by: 1. checking if the window was _moved_ as a part of this message 2. getting the monitor that the window will be moved onto 3. If that monitor is different than the monitor the window is currently on, then * calculate how big the quake window should be on that monitor * tell the OS that's where we'd like to be. ## Validation Steps Performed * <kbd>win+shift+arrows</kbd> works right now * normal quake summoning still works right
🎉This issue was addressed in #10744, which has now been successfully released as Handy links: |
🎉This issue was addressed in #10744, which has now been successfully released as Handy links: |
I've been toying with
quake
mode and noticed some odd behaviors when running on multiple monitors, where one is on a vertical orientation. On first summon quake mode dropped down from my desired "main" monitor. Consecutive summons have it split between two monitors but never on a single monitor. I tried changing themonitor
anddesktop
values of the command without luck.In the attached image you can see that the window dropped down to my left most monitor (which is vertical).
It appears the drop down is tracing location of mouse relative to left|right of center in regards to the entire resolution of the combined screens (?).
If my mouse is towards left of center it will render on left most monitor, with the right edge meeting center of main screen.
If my mouse is to the right of center of main screen it renders on the right "half" of the resolution, with the left edge meeting center of main monitor.
Last interesting thing to happen is -- if my mouse is on the left edge of my left most screen it renders off screen.
The text was updated successfully, but these errors were encountered: