Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an "openSystemMenu" keybinding #11018

Closed
PankajBhojwani opened this issue Aug 23, 2021 · 1 comment · Fixed by #11086
Closed

Add an "openSystemMenu" keybinding #11018

PankajBhojwani opened this issue Aug 23, 2021 · 1 comment · Fixed by #11086
Assignees
@PankajBhojwani
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@PankajBhojwani
Copy link
Contributor

Description of the new feature/enhancement

Here's a really silly thought. What if we just add a new "openSystemMenu" binding? We could be done with this whole issue and allow people to re-bind it to whatever they want! All we'd need to do is move _OpenSystemMenu to IslandWindow, hook up some events from AppHost/AppLogic/TerminalPage (ugh hopefully not all of them) and... we're off to the races! We can also do that work later and mark this part with a big TODO that links to a workitem that says what I just said above^

Originally posted in 10988
@PankajBhojwani PankajBhojwani added the Issue-Task It's a feature request, but it doesn't really need a major design. label Aug 23, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 23, 2021
@PankajBhojwani PankajBhojwani self-assigned this Aug 23, 2021
@PankajBhojwani PankajBhojwani added this to the Terminal v1.12 milestone Aug 23, 2021
@PankajBhojwani PankajBhojwani added Area-Input Related to input processing (key presses, mouse, etc.) Product-Terminal The new Windows Terminal. labels Aug 23, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 23, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 27, 2021
@PankajBhojwani PankajBhojwani mentioned this issue Aug 30, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 30, 2021
@ghost ghost closed this as completed in #11086 Sep 10, 2021
@ghost ghost removed the In-PR This issue has a related PR label Sep 10, 2021
ghost pushed a commit that referenced this issue Sep 10, 2021
@PankajBhojwani
Add an openSystemMenu keybinding (#11086)
97722d3 
## Summary of the Pull Request
Basically undoes #10988  in favour of implementing it as described in #11018 

## PR Checklist
* [x] Closes #11018 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [X] Tests added/passed
* [X] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [X] Schema updated.
* [x] I work here

## Validation Steps Performed

- alt+space opens the system menu by default
- when alt+space is bound, the keys do not get send to terminal
- right-click on the tab bar didn't break (still opens system menu at the location of the cursor)
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 10, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11086, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Add an openSystemMenu keybinding microsoft/terminal
2 participants
@DHowett @PankajBhojwani