Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple failing unit tests #11339

Closed
j4james opened this issue Sep 26, 2021 · 3 comments · Fixed by #11394
Closed

Multiple failing unit tests #11339

j4james opened this issue Sep 26, 2021 · 3 comments · Fixed by #11394
Assignees
@lhecker
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@j4james
Copy link
Collaborator

j4james commented Sep 26, 2021

Windows Terminal version (or Windows build number)

10.0.18363.1500, Commit 2be394f

Other Software

No response

Steps to reproduce

  1. Checkout a recent version of the Terminal.
  2. Build the code.
  3. Execute runut in the tools directory.

Expected Behavior

The unit tests should all pass.

Actual Behavior

I'm getting quite a lot of failures.

TerminalAppLocalTests::CommandlineTest::ParseFocusTabArgs#metadataSet0 [Failed]
TerminalAppLocalTests::CommandlineTest::ParseFocusTabArgs#metadataSet1 [Failed]
TerminalAppLocalTests::SettingsTests::TestIterateCommands [Failed]
TerminalAppLocalTests::SettingsTests::TestIterateOnGeneratedNamedCommands [Failed]
TerminalAppLocalTests::SettingsTests::TestIterateOnBadJson [Failed]
TerminalAppLocalTests::SettingsTests::TestNestedCommands [Failed]
TerminalAppLocalTests::SettingsTests::TestNestedInNestedCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestNestedInIterableCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestIterableInNestedCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestMixedNestedAndIterableCommand [Failed]
TerminalAppLocalTests::SettingsTests::TestIterableColorSchemeCommands [Failed]
TerminalAppLocalTests::TabTests::MoveFocusFromZoomedPane [Failed]
SettingsModelLocalTests::ProfileTests::TestGenGuidsForProfiles [Failed]
SettingsModelLocalTests::DeserializationTests::TestLayerUserDefaultsOnDynamics [Failed]
SettingsModelLocalTests::SerializationTests::Profile [Failed]

I haven't actually looked to see what's going wrong, so it's possible it's just me.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 26, 2021
@zadjii-msft
Copy link
Member

Yep, I've got a similar set of errors over here. I'm gonna tap in @lhecker for his settings refactor work.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products. labels Sep 27, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 27, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Sep 27, 2021
@lhecker
Copy link
Member

lhecker commented Sep 27, 2021

Oh... We don't run those as part of CI, right? I forgot about that...

@Rosefield
Copy link
Contributor

I added a fix to the MoveFocusFromZoomedPane test (to make it confirm that we are still zoomed instead of not zoomed) to #11153

@lhecker lhecker mentioned this issue Oct 1, 2021
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 1, 2021
@ghost ghost closed this as completed in #11394 Oct 5, 2021
@ghost ghost removed the In-PR This issue has a related PR label Oct 5, 2021
ghost pushed a commit that referenced this issue Oct 5, 2021
@lhecker
Fix failing TestHostApp unit tests (#11394)
0b552e1 
This commit fixes various failing TestHostApp unit tests.
Most of these broke as part of 168d28b (#11184).

## PR Checklist
* [x] Closes #11339
* [x] I work here
* [x] Tests added/passed
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Oct 5, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Fix failing TestHostApp unit tests microsoft/terminal
4 participants
@lhecker @j4james @Rosefield @zadjii-msft