Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade effect behind close diaglogue covers part of the window #11770

Closed
AdrianDeWinter opened this issue Nov 17, 2021 · 3 comments
Closed

Fade effect behind close diaglogue covers part of the window #11770

AdrianDeWinter opened this issue Nov 17, 2021 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@AdrianDeWinter
Copy link

Windows Terminal version

1.112921.0

Windows build number

19043.1348

Other Software

No response

Steps to reproduce

Open Terminal with more tah one tab.
Set the Window to fullscreen.
Attempt to close the window.
The "Do you want to close all tabs?" dialogue appears

Expected Behavior

The fade effect should cover the entire window behind the dialogue, not just a corner of it

Actual Behavior

Only a part of the window gets faded to white, specifically about a quarter in the top left corner, of roughly the the same size as the default terminal window

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 17, 2021
@KalleOlaviNiemitalo
Copy link

This is a duplicate of #2380, which was closed as a duplicate of microsoft/microsoft-ui-xaml#3577.

(Personally, I'm more used to a workflow where I keep an issue open in the affected project and mark it blocked by the issue in the other project. Not sure how well GitHub supports that, though.)

@zadjii-msft
Copy link
Member

More often than not, I usually do keep the issue on our side open, but also 🤷 That one's an OS-side bug so it's not like we'll need to ingest a new WinUI version to get the fix. When it gets ported to xaml islands and serviced, we should just magically stop hearing about this 😛

/dup #2380

@ghost
Copy link

ghost commented Nov 17, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 17, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 17, 2021
DHowett pushed a commit that referenced this issue Jan 23, 2023
Major thanks to @dongle-the-gadget in microsoft/microsoft-ui-xaml#3577 (comment) for coming up with this workaround.

This PR will manually forward a `WM_SIZE` message to our `CoreWindow`, to trigger the `ContentDialog` to resize itself. 

We always closed these issues as dupes of the upstream one, so this doesn't actually close anything.
HOWEVER, these are the following issues that reported this bug:
- #2380
- #4463
- #5252
- #5810
- #6181
- #7113
- #7225
- #8245
- #8496
- #8643
- #9336
- #9563
- #5808
- #10351
- #10634
- #10995
- #11770
- #13796
DHowett pushed a commit that referenced this issue Jan 23, 2023
Major thanks to @dongle-the-gadget in microsoft/microsoft-ui-xaml#3577 (comment) for coming up with this workaround.

This PR will manually forward a `WM_SIZE` message to our `CoreWindow`, to trigger the `ContentDialog` to resize itself.

We always closed these issues as dupes of the upstream one, so this doesn't actually close anything.
HOWEVER, these are the following issues that reported this bug:
- #2380
- #4463
- #5252
- #5810
- #6181
- #7113
- #7225
- #8245
- #8496
- #8643
- #9336
- #9563
- #5808
- #10351
- #10634
- #10995
- #11770
- #13796

(cherry picked from commit a4cf4e2)
Service-Card-Id: 87727806
Service-Version: 1.17
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants