Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings - Startup]: Name is not defined for the button present under 'Startup' tab. #13019

Closed
Tracked by #9990
ghost opened this issue May 2, 2022 · 4 comments · Fixed by #13032
Closed
Tracked by #9990

[Settings - Startup]: Name is not defined for the button present under 'Startup' tab. #13019

ghost opened this issue May 2, 2022 · 4 comments · Fixed by #13032
Labels
A11yCO Accessibility tracking A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.14

Comments

@ghost
Copy link

ghost commented May 2, 2022

Windows Terminal version

1.13.10984.0

Windows build number

22598.200

Other Software

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22598.200)
Screen Reader: Narrator

Steps to reproduce

Repro Steps:
Open Windows Terminal.
Open Settings page using "Ctrl + ',' ".
Verify that Name is not defined for the button present under 'Startup' tab.

User Experience: -> Priority 1
User who relies on screen reader will be affected and not be able to know what the control is and what is its functionality if name is not defined for the control.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value.html

Attachments:
Name is not defined for the button present under 'Startup' tab..zip

Expected Behavior

Name should be defined for the button present under 'Startup' tab.
Screen reader should announce "When terminal starts button collapse/expand button".

Actual Behavior

Name is not defined for the button present under 'Startup' tab.
Screen reader announces, "group collapse".
@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yCO Accessibility tracking A11ySev2 Accessibility tracking Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 2, 2022
@zadjii-msft zadjii-msft mentioned this issue May 2, 2022
Open
12 tasks
@zadjii-msft zadjii-msft added this to the Terminal v1.14 milestone May 2, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 2, 2022
@zadjii-msft
Copy link
Member

Hey look, @carlos-zamora was right, this one would get picked up.

Previous thread: #12317

@zadjii-msft zadjii-msft mentioned this issue May 2, 2022
Closed
@PankajBhojwani PankajBhojwani mentioned this issue May 3, 2022
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label May 3, 2022
@ghost ghost closed this as completed in #13032 May 4, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 4, 2022
ghost pushed a commit that referenced this issue May 4, 2022
@PankajBhojwani
Add automation properties to expander-style settings (#13032)
71cbdc8 
## Summary of the Pull Request
Make sure we set `Name` and `FullDescription` on expander-style settings in the SUI

## PR Checklist
* [x] Closes #13019 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
Accessibility insights now shows the name/full description for the expander-style settings
@DHowett DHowett reopened this May 4, 2022
carlos-zamora pushed a commit that referenced this issue May 12, 2022
@PankajBhojwani @carlos-zamora
Add automation properties to expander-style settings (#13032)
7f1c78e 
## Summary of the Pull Request
Make sure we set `Name` and `FullDescription` on expander-style settings in the SUI

## PR Checklist
* [x] Closes #13019
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
Accessibility insights now shows the name/full description for the expander-style settings

(cherry picked from commit 71cbdc8)
Service-Card-Id: 81446420
Service-Version: 1.13
@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #13032, which has now been successfully released as Windows Terminal v1.13.1143.:tada:

Handy links:

@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #13032, which has now been successfully released as Windows Terminal Preview v1.14.143.:tada:

Handy links:

@ghost
Copy link
Author

ghost commented May 27, 2022 •
edited by ghost
Loading

Closing as fixed now Version: 1.13.11432.0

@ghost ghost closed this as completed May 27, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11yCO Accessibility tracking A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.14
Development

Successfully merging a pull request may close this issue.

Add automation properties to expander-style settings microsoft/terminal
2 participants
@DHowett @zadjii-msft