Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons flash for a frame when switching tabs #1333

Closed
zadjii-msft opened this issue Jun 19, 2019 · 2 comments · Fixed by #2376
Closed

Icons flash for a frame when switching tabs #1333

zadjii-msft opened this issue Jun 19, 2019 · 2 comments · Fixed by #2376
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@zadjii-msft
Copy link
Member

Every time we change the focus of a tab/pane, we attempt to update the icon and titlebar of the tab. Since we're only storing a path to the icon in memory, every time you change focus, we need to reload the icon from disk to create the Icon.

This is obviously bad. we should instead be caching the icon once, and just updating the Icon with that pre-loaded one. Or at the very least, we should cache what the path to the last icon we set was, and only reload the icon if the path is different.
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jun 19, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jun 19, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 19, 2019
@DHowett-MSFT
Copy link
Contributor

This will also be helped by #1205, but not totally fixed by it.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 20, 2019
zadjii-msft added a commit that referenced this issue Aug 9, 2019
@zadjii-msft
Only update the icon of a tab it the icon actually _changed_
b94c767 
  * fixes #1333
  * Also tangentially fixes #2339
@zadjii-msft zadjii-msft mentioned this issue Aug 9, 2019
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 9, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 14, 2019
DHowett-MSFT pushed a commit that referenced this issue Aug 14, 2019
@zadjii-msft @DHowett
Only update the icon of a tab it the icon actually _changed_ (#2376)
8999c66 
Fixes #1333.
Fixes #2329.
@ghost
Copy link

ghost commented Aug 27, 2019

🎉This issue was addressed in #2376, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Only update the icon of a tab it the icon actually _changed_ microsoft/terminal
2 participants
@DHowett-MSFT @zadjii-msft