Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on exit: IRenderEngine #13356

Closed
carlos-zamora opened this issue Jun 21, 2022 · 2 comments
Closed

Crash on exit: IRenderEngine #13356

carlos-zamora opened this issue Jun 21, 2022 · 2 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.

Comments

@carlos-zamora
Copy link
Member

Windows Terminal version

main at 0b97c7b

Windows build number

10.0.25145.0

Other Software

settings.json ``` { "$help": "https://aka.ms/terminal-documentation", "$schema": "https://aka.ms/terminal-profiles-schema", "actions": [ { "command": { "action": "copy", "singleLine": false }, "keys": "ctrl+c" }, { "command": "paste", "keys": "ctrl+v" }, { "command": "find", "keys": "ctrl+shift+f" }, { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" } ], "copyFormatting": "none", "copyOnSelect": true, "defaultProfile": "{574e775e-4f2a-5b96-ac1e-a2962a402336}", "profiles": { "defaults": {}, "list": [ { "commandline": "%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe", "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "hidden": false, "name": "Windows PowerShell" }, { "commandline": "%SystemRoot%\\System32\\cmd.exe", "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "hidden": false, "name": "Command Prompt" }, { "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}", "hidden": false, "name": "PowerShell", "source": "Windows.Terminal.PowershellCore", "unfocusedAppearance": { "colorScheme": "Campbell Powershell" } }, { "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}", "hidden": false, "name": "Ubuntu", "source": "Windows.Terminal.Wsl" }, { "guid": "{83bfd87d-26a9-5110-afc4-072b1fb35993}", "hidden": false, "name": "Developer Command Prompt for VS 2022 [Preview]", "source": "Windows.Terminal.VisualStudio" }, { "guid": "{921abc0f-2e8e-56ef-a73d-9aff38500feb}", "hidden": false, "name": "Developer PowerShell for VS 2022 [Preview]", "source": "Windows.Terminal.VisualStudio" } ] }, "schemes": [ { "background": "#0C0C0C", "black": "#0C0C0C", "blue": "#0037DA", "brightBlack": "#767676", "brightBlue": "#3B78FF", "brightCyan": "#61D6D6", "brightGreen": "#16C60C", "brightPurple": "#B4009E", "brightRed": "#E74856", "brightWhite": "#F2F2F2", "brightYellow": "#F9F1A5", "cursorColor": "#FFFFFF", "cyan": "#3A96DD", "foreground": "#CCCCCC", "green": "#13A10E", "name": "Campbell", "purple": "#881798", "red": "#C50F1F", "selectionBackground": "#FFFFFF", "white": "#CCCCCC", "yellow": "#C19C00" }, { "background": "#12456", "black": "#0C0C0C", "blue": "#0037DA", "brightBlack": "#767676", "brightBlue": "#3B78FF", "brightCyan": "#61D6D6", "brightGreen": "#16C60C", "brightPurple": "#B4009E", "brightRed": "#E74856", "brightWhite": "#F2F2F2", "brightYellow": "#F9F1A5", "cursorColor": "#FFFFFF", "cyan": "#3A96DD", "foreground": "#CCCCCC", "green": "#13A10E", "name": "Campbell Powershell", "purple": "#881798", "red": "#C50F1F", "selectionBackground": "#FFFFFF", "white": "#CCCCCC", "yellow": "#C19C00" }, { "background": "#282C34", "black": "#282C34", "blue": "#61AFEF", "brightBlack": "#5A6374", "brightBlue": "#61AFEF", "brightCyan": "#56B6C2", "brightGreen": "#98C379", "brightPurple": "#C678DD", "brightRed": "#E06C75", "brightWhite": "#DCDFE4", "brightYellow": "#E5C07B", "cursorColor": "#FFFFFF", "cyan": "#56B6C2", "foreground": "#DCDFE4", "green": "#98C379", "name": "One Half Dark", "purple": "#C678DD", "red": "#E06C75", "selectionBackground": "#FFFFFF", "white": "#DCDFE4", "yellow": "#E5C07B" }, { "background": "#FAFAFA", "black": "#383A42", "blue": "#0184BC", "brightBlack": "#4F525D", "brightBlue": "#61AFEF", "brightCyan": "#56B5C1", "brightGreen": "#98C379", "brightPurple": "#C577DD", "brightRed": "#DF6C75", "brightWhite": "#FFFFFF", "brightYellow": "#E4C07A", "cursorColor": "#4F525D", "cyan": "#0997B3", "foreground": "#383A42", "green": "#50A14F", "name": "One Half Light", "purple": "#A626A4", "red": "#E45649", "selectionBackground": "#FFFFFF", "white": "#FAFAFA", "yellow": "#C18301" }, { "background": "#002B36", "black": "#002B36", "blue": "#268BD2", "brightBlack": "#073642", "brightBlue": "#839496", "brightCyan": "#93A1A1", "brightGreen": "#586E75", "brightPurple": "#6C71C4", "brightRed": "#CB4B16", "brightWhite": "#FDF6E3", "brightYellow": "#657B83", "cursorColor": "#FFFFFF", "cyan": "#2AA198", "foreground": "#839496", "green": "#859900", "name": "Solarized Dark", "purple": "#D33682", "red": "#DC322F", "selectionBackground": "#FFFFFF", "white": "#EEE8D5", "yellow": "#B58900" }, { "background": "#FDF6E3", "black": "#002B36", "blue": "#268BD2", "brightBlack": "#073642", "brightBlue": "#839496", "brightCyan": "#93A1A1", "brightGreen": "#586E75", "brightPurple": "#6C71C4", "brightRed": "#CB4B16", "brightWhite": "#FDF6E3", "brightYellow": "#657B83", "cursorColor": "#002B36", "cyan": "#2AA198", "foreground": "#657B83", "green": "#859900", "name": "Solarized Light", "purple": "#D33682", "red": "#DC322F", "selectionBackground": "#FFFFFF", "white": "#EEE8D5", "yellow": "#B58900" }, { "background": "#000000", "black": "#000000", "blue": "#3465A4", "brightBlack": "#555753", "brightBlue": "#729FCF", "brightCyan": "#34E2E2", "brightGreen": "#8AE234", "brightPurple": "#AD7FA8", "brightRed": "#EF2929", "brightWhite": "#EEEEEC", "brightYellow": "#FCE94F", "cursorColor": "#FFFFFF", "cyan": "#06989A", "foreground": "#D3D7CF", "green": "#4E9A06", "name": "Tango Dark", "purple": "#75507B", "red": "#CC0000", "selectionBackground": "#FFFFFF", "white": "#D3D7CF", "yellow": "#C4A000" }, { "background": "#FFFFFF", "black": "#000000", "blue": "#3465A4", "brightBlack": "#555753", "brightBlue": "#729FCF", "brightCyan": "#34E2E2", "brightGreen": "#8AE234", "brightPurple": "#AD7FA8", "brightRed": "#EF2929", "brightWhite": "#EEEEEC", "brightYellow": "#FCE94F", "cursorColor": "#000000", "cyan": "#06989A", "foreground": "#555753", "green": "#4E9A06", "name": "Tango Light", "purple": "#75507B", "red": "#CC0000", "selectionBackground": "#FFFFFF", "white": "#D3D7CF", "yellow": "#C4A000" }, { "background": "#000000", "black": "#000000", "blue": "#80", "brightBlack": "#808080", "brightBlue": "#0000FF", "brightCyan": "#00FFFF", "brightGreen": "#00FF00", "brightPurple": "#FF00FF", "brightRed": "#FF0000", "brightWhite": "#FFFFFF", "brightYellow": "#FFFF00", "cursorColor": "#FFFFFF", "cyan": "#8080", "foreground": "#C0C0C0", "green": "#8000", "name": "Vintage", "purple": "#800080", "red": "#800000", "selectionBackground": "#FFFFFF", "white": "#C0C0C0", "yellow": "#808000" } ] } ```

Steps to reproduce

  1. open terminal
  2. close terminal

Expected Behavior

not a crash

Actual Behavior

crash. Here's the call stack:

Call Stack ``` ntdll.dll!00007ffeb1995840() Unknown ntdll.dll!00007ffeb19f818c() Unknown ntdll.dll!00007ffeb1980126() Unknown > Microsoft.Terminal.Control.dll!std::default_delete::operator()(Microsoft::Console::Render::IRenderEngine * _Ptr) Line 3125 C++ Microsoft.Terminal.Control.dll!std::unique_ptr>::~unique_ptr>() Line 3235 C++ Microsoft.Terminal.Control.dll!winrt::Microsoft::Terminal::Control::implementation::ControlCore::~ControlCore() Line 231 C++ [External Code] Microsoft.Terminal.Control.dll!winrt::impl::root_implements::NonDelegatingRelease() Line 7385 C++ Microsoft.Terminal.Control.dll!winrt::impl::root_implements::Release() Line 7267 C++ Microsoft.Terminal.Control.dll!winrt::implements::Release() Line 7860 C++ Microsoft.Terminal.Control.dll!winrt::com_ptr::unconditional_release_ref() Line 2545 C++ Microsoft.Terminal.Control.dll!winrt::com_ptr::release_ref() Line 2540 C++ Microsoft.Terminal.Control.dll!winrt::com_ptr::~com_ptr() Line 2371 C++ [External Code] Microsoft.Terminal.Control.dll!winrt::impl::root_implements::NonDelegatingRelease() Line 7385 C++ Microsoft.Terminal.Control.dll!winrt::impl::root_implements::Release() Line 7267 C++ Microsoft.Terminal.Control.dll!winrt::implements::Release() Line 7860 C++ Microsoft.Terminal.Control.dll!winrt::impl::produce_base::Release() Line 6935 C++ Microsoft.Terminal.Control.dll!winrt::Windows::Foundation::IUnknown::unconditional_release_ref() Line 2147 C++ Microsoft.Terminal.Control.dll!winrt::Windows::Foundation::IUnknown::release_ref() Line 2142 C++ Microsoft.Terminal.Control.dll!winrt::Windows::Foundation::IUnknown::~IUnknown() Line 2046 C++ [External Code] Microsoft.Terminal.Control.dll!winrt::Microsoft::Terminal::Control::implementation::TermControl::~TermControl() Line 656 C++ [External Code] Microsoft.Terminal.Control.dll!winrt::impl::root_implements::NonDelegatingRelease() Line 7385 C++ Microsoft.Terminal.Control.dll!winrt::impl::root_implements::Release() Line 7267 C++ Microsoft.Terminal.Control.dll!winrt::implements::Release() Line 7860 C++ Microsoft.Terminal.Control.dll!winrt::impl::produce_base::Release() Line 6935 C++ [External Code] WindowsTerminal.exe!winrt::impl::consume_Windows_Foundation_IClosable::Close() Line 121 C++ WindowsTerminal.exe!AppHost::~AppHost() Line 149 C++ WindowsTerminal.exe!wWinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, wchar_t * __formal, int __formal) Line 199 C++ [External Code] ```
@carlos-zamora carlos-zamora added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. labels Jun 21, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.15 milestone Jun 21, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 21, 2022
@zadjii-msft
Copy link
Member

@carlos-zamora you still seeing this one?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 5, 2022
@carlos-zamora
Copy link
Member Author

Not anymore. I could've sworn I saw it earlier today. 🤷

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2022
@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

2 participants