Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI and audit build to the WinDev scale set pool #8080

Merged
3 commits merged into from
Oct 28, 2020
Merged

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Oct 28, 2020

This pull request switches us to the new WinDev scaleset agent pool. It
should be faster than the hosted pool, and the larger disks allow us to
get rid of our PCH cleanup step.

@DHowett DHowett changed the title don't look yet- Dev/duhowett/windevpool Move build to the WinDev scale set pool Oct 28, 2020
@DHowett DHowett changed the title Move build to the WinDev scale set pool Move CI and audit build to the WinDev scale set pool Oct 28, 2020
@DHowett
Copy link
Member Author

DHowett commented Oct 28, 2020

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 28, 2020
@ghost
Copy link

ghost commented Oct 28, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 28 Oct 2020 20:04:45 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<happy CI noises>

# The build agents cannot currently support parallel build due to the
# memory requirements of our PCH files.
maximumCpuCount: false
maximumCpuCount: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO MUCH YAY

pool: { vmImage: windows-2019 }
pool: "windevbuildagents"
# The public pool is also an option!
# pool: { vmImage: windows-2019 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you not mention that the OpenConsoleCleanPch flag should be on too if you go to the public pool?

@ghost ghost merged commit 4daed9d into main Oct 28, 2020
@ghost ghost deleted the dev/duhowett/windevpool branch October 28, 2020 20:49
@Mukul1127 Mukul1127 mentioned this pull request Feb 4, 2022
@XXXE88 XXXE88 mentioned this pull request Jul 10, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants