Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Terminal Preview - Read-only pane pop-up on tab switch #13461

Closed
MikeMM70 opened this issue Jul 8, 2022 · 6 comments · Fixed by #13483
Closed

Windows Terminal Preview - Read-only pane pop-up on tab switch #13461

MikeMM70 opened this issue Jul 8, 2022 · 6 comments · Fixed by #13483
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.16

Comments

@MikeMM70
Copy link

MikeMM70 commented Jul 8, 2022

Windows Terminal version

Windows Terminal Preview Version: 1.15.1862.0

Windows build number

10.0.19044.1766

Other Software

Seems to be on anything I have open in terminal

Steps to reproduce

Open 3 terminal tabs, PowerShell 7.2.5, Windows PowerShell 5.1, or command prompt. Set a keybind to toggle pane read-only mode (mine is set to ctrl-shift-), then toggle one of the tabs to read-only. Click on the 3 tabs in any order. Pop-up stating "Read-only mode enabled" appears both switching to AND from that read-only tab to/from other tabs.
image
image

This doesn't happen in my currently installed non-preview version Windows Terminal Version: 1.13.11431.0 (I should probably update, but I don't use the non-preview version much)

Expected Behavior

Personally, no popups at all, but if you have to, only when switching to the read-only tab. I did not try with split panes, I don't use them much, though I like the feature in theory.

Actual Behavior

Pop-up stating "Read-only mode enabled" appears both switching to AND from that read-only tab to/from other tabs.

I did discover that you can't set the settings tab to read-only, though I can live without that :)
@MikeMM70 MikeMM70 added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 8, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 8, 2022
@zadjii-msft
Copy link
Member

oh my god, I'm confident that this is because of the focus in/out events. We should probably not suppress those, even in read only mode. Trick is, can we get the input generated for those events past the read-only guard simply?

@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Priority-1 A description (P1) labels Jul 8, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 8, 2022
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jul 8, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 8, 2022
@MikeMM70
Copy link
Author

MikeMM70 commented Jul 8, 2022

I just updated my non-preview version to 1.14.1861.0 and I get the same bad behavior, just FYI.

Thank you for all the work you all do on making this otherwise awesome software!

@zadjii-msft zadjii-msft mentioned this issue Jul 11, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 11, 2022
@ghost ghost closed this as completed in #13483 Jul 12, 2022
ghost pushed a commit that referenced this issue Jul 12, 2022
@zadjii-msft
Send focus events even in ReadOnly mode (#13483)
b4a52c8 
Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection. 

* closes #13461
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 12, 2022
DHowett pushed a commit that referenced this issue Jul 15, 2022
@zadjii-msft @DHowett
Send focus events even in ReadOnly mode (#13483)
1a56bc5 
Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection.

* closes #13461

(cherry picked from commit b4a52c8)
Service-Card-Id: 84111370
Service-Version: 1.14
DHowett pushed a commit that referenced this issue Jul 19, 2022
@zadjii-msft @DHowett
Send focus events even in ReadOnly mode (#13483)
a4a12ef 
Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection.

* closes #13461

(cherry picked from commit b4a52c8)
Service-Card-Id: 84111371
Service-Version: 1.15
@RedX2501
Copy link

RedX2501 commented Aug 2, 2022

I'm still seeing this on 1.15.1862

@zadjii-msft
Copy link
Member

@RedX2501 That makes sense, it looks like #13483 isn't in any release branches yet. The bot should come through and post an update when it does show up in one!

@ghost
Copy link

ghost commented Aug 5, 2022

🎉This issue was addressed in #13483, which has now been successfully released as Windows Terminal v1.14.196.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 5, 2022

🎉This issue was addressed in #13483, which has now been successfully released as Windows Terminal Preview v1.15.200.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.16
Development

Successfully merging a pull request may close this issue.

Send focus events even in ReadOnly mode microsoft/terminal
3 participants
@RedX2501 @MikeMM70 @zadjii-msft