Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select all marker visibility #13485

Closed
elsaco opened this issue Jul 12, 2022 · 1 comment · Fixed by #13656
Closed

select all marker visibility #13485

elsaco opened this issue Jul 12, 2022 · 1 comment · Fixed by #13656
Assignees
@carlos-zamora
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.16

Comments

@elsaco
Copy link

elsaco commented Jul 12, 2022

Windows Terminal version

1.15.1863.0

Windows build number

10.0.22000.778

Other Software

No response

Steps to reproduce

  • clear buffer
  • display some info, not to fill the buffer
  • ctrl+shift+a

Expected Behavior

No response

Actual Behavior

  • when buffer not full (no scrollbar) crtl+shift+a shows a marker top left.
  • with full buffer (scrollbar visible) there is no marker, ever scrolling to top of buffer.

Partial buffer screenshot, with marker visible:
crtl+a_mark_shown
@elsaco elsaco added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 12, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 12, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 12, 2022
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Jul 12, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 12, 2022
This was referenced Aug 2, 2022
Open
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 2, 2022
@ghost ghost closed this as completed in #13656 Aug 2, 2022
ghost pushed a commit that referenced this issue Aug 2, 2022
@carlos-zamora
Scroll to top when select all action is invoked (#13656)
a9c3b77 
## Summary of the Pull Request
In general, when a selection marker is shown, we should scroll to it. The `selectAll` action adds a selection marker, but we don't scroll to it. This PR makes it such that we do do that.

Epic: #4993 
Closes #13485
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 2, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉This issue was addressed in #13656, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.16
Development

Successfully merging a pull request may close this issue.

Scroll to top when select all action is invoked microsoft/terminal
3 participants
@elsaco @carlos-zamora @zadjii-msft