Mark Mode should preempt key bindings, and work with anything that causes scrolling... #13533

Jaykul · 2022-07-18T16:18:29Z

Windows Terminal version

1.15.1862.0

Windows build number

10.0.19042.0

Other Software

No response

Steps to reproduce

I know the mark mode keyboard selection is still very early days. I just wanted to make sure the expected behaviors are all covered, and I didn't see this called out.

Any hotkey that pre-exists the mark mode currently interfere with selection. That is, currently:

Mark mode seems to only works with the default windows text navigation keys: the arrows, PgUp/PgDn, home/end.
Selecting requires turning on mark mode and then holding shift while pressing those keys.

If the user has an "Action" configured for Ctrl+Shift+Home or Ctrl+Shift+PgUp or whatever, that action will trigger instead of the selection.

Additionally, nothing else that scrolls the buffer causes the mark to move or select:

Scrolling with the mouse
Scrolling with scrollToMark
Scrolling via the command palette (Ctrl+Shift+P)

On top of that, we can't usefully turn on mark mode after scrolling, because it always appears at the bottom.

Expected Behavior

Mark mode should probably be called "selection" mode, to disambiguate with the new "marks" ...

Mark mode should disregard actions that consume Arrows/PgUp/PgDn/Home/End -- or possibly, should ignore all actions except selection-specific actions or Esc to cancel, changing all the hotkeys like a vi mode does.

The "mark" should follow the scroll buffer if the buffer is scrolled via other actions. Ideally, it should select when that happens with SHIFT pressed.

The mark should always appear within the visible buffer when it's invoked, not only at the bottom/prompt.

Actual Behavior

The mark only ever appears at the prompt, and can only be used if you haven't configured actions over the default text selection keys.

The text was updated successfully, but these errors were encountered:

zadjii-msft · 2022-07-18T17:04:56Z

There's a lot to unpack here, I'll make sure this is at the top of the discussion order ~~this afternoon~~ EDIT: tomorrow due to some oofages. Thanks!

zadjii-msft · 2022-07-19T21:42:00Z

quick discussion notes:

Mark mode should probably be called "selection" mode, to disambiguate with the new "marks" ...

meh, I think we're more attached to calling this "Mark Mode" than we are to calling the scrollbar marks "marks".

Mark mode should disregard actions that consume Arrows/PgUp/PgDn/Home/End -- or possibly, should ignore all actions except selection-specific actions or Esc to cancel, changing all the hotkeys like a vi mode does.

yes - we think we have an issue for this. This gets more complicated with things like nextMatch/prevMatch, find in general. We'll noodle on this one.

The "mark" should follow the scroll buffer if the buffer is scrolled via other actions. Ideally, it should select when that happens with SHIFT pressed.

maybe not?

The mark should always appear within the visible buffer when it's invoked, not only at the bottom/prompt.

for sure

over to @carlos-zamora

carlos-zamora · 2022-07-20T17:32:30Z

Ok, I added this to the main epic #4993. I also have a few notes on a few of these:

Mark mode should disregard actions that consume Arrows/PgUp/PgDn/Home/End -- or possibly, should ignore all actions except selection-specific actions or Esc to cancel, changing all the hotkeys like a vi mode does.

I was wrong. No issue tracking this. So congrats, this issue is now tracking that haha.

The "mark" should follow the scroll buffer if the buffer is scrolled via other actions. Ideally, it should select when that happens with SHIFT pressed.

This one has an issue: #4985. I closed it because selecting by viewport automatically scrolls, which mostly satisfies the need. That said since this is the second time it's been asked for (especially after mark mode is available), I'll reopen it.

carlos-zamora · 2022-08-02T20:08:56Z

Mark mode should probably be called "selection" mode, to disambiguate with the new "marks" ...

For now, scrollbar marks are in experimental so we'll rename them as a part of the polishing process. Added a comment in megathread: Scrollbar Marks #11000 to track this

Mark mode should disregard actions that consume Arrows/PgUp/PgDn/Home/End -- or possibly, should ignore all actions except selection-specific actions or Esc to cancel, changing all the hotkeys like a vi mode does.

Fixed by #13659

The mark should always appear within the visible buffer when it's invoked, not only at the bottom/prompt.

Fixed by #13405. ~~I need to backport that change still.~~ Backported via #13660

carlocardella · 2022-08-02T23:05:01Z

quick discussion notes:

Mark mode should probably be called "selection" mode, to disambiguate with the new "marks" ...

meh, I think we're more attached to calling this "Mark Mode" than we are to calling the scrollbar marks "marks".

Uhm... seems counterintuitive to me... "mark mode" allows to select some text, make a selection. Also, most (all) tools/editors I am aware of call this "selection", why do we want to call it "mark"?

zadjii-msft · 2022-08-03T11:43:31Z

why do we want to call it "mark"?

Kinda just because that's what the vintage console called it:

We've used "mark mode" internally to refer to "the editing mode in which the keyboard input modifies the selection region" for years.

That being said, "Selection mode" is pretty obvious what it's doing. And, calling it "selection mode" would immediately disambiguate it from the implementation in conhost. Idk, back to the discussion board it goes.

## Summary of the Pull Request This PR moves the key handling for mark mode into a helper method that is then called before an action/key binding is attempted. ## References Epic: #4993 Closes #13533 ## Validation Steps Performed - Add custom keybinding to "down" arrow key - in mark mode --> selection updates appropriately - out of mark mode --> keybinding executed

This PR moves the key handling for mark mode into a helper method that is then called before an action/key binding is attempted. Epic: #4993 Closes #13533 - Add custom keybinding to "down" arrow key - in mark mode --> selection updates appropriately - out of mark mode --> keybinding executed Amended by DHowett to remove URL targeting features. (cherry picked from commit 70313db) Service-Card-Id: 84711521 Service-Version: 1.15

ghost · 2022-09-13T17:02:50Z

🎉This issue was addressed in #13659, which has now been successfully released as Windows Terminal v1.15.252.:tada:

Handy links:

ghost · 2022-09-13T17:05:41Z

🎉This issue was addressed in #13659, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

Jaykul added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 18, 2022

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 18, 2022

zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Jul 18, 2022

zadjii-msft assigned carlos-zamora Jul 19, 2022

zadjii-msft added this to the Terminal v1.16 milestone Jul 20, 2022

carlos-zamora mentioned this issue Jul 20, 2022

Scenario: Keyboard Text Selection #4993

Open

11 tasks

carlos-zamora mentioned this issue Jul 20, 2022

Moving the cursor when scrolling in the history to select text #4985

Closed

carlos-zamora removed the Needs-Discussion Something that requires a team discussion before we can proceed label Jul 25, 2022

zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Priority-1 A description (P1) labels Jul 26, 2022

carlos-zamora mentioned this issue Aug 2, 2022

Make Mark Mode keybindings precede custom keybindings #13659

Merged

ghost added the In-PR This issue has a related PR label Aug 2, 2022

carlos-zamora mentioned this issue Aug 2, 2022

megathread: Scrollbar Marks #11000

Open

37 tasks

zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Aug 3, 2022

DHowett removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Aug 12, 2022

zadjii-msft added the Product-Terminal The new Windows Terminal. label Aug 15, 2022

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 15, 2022

ghost closed this as completed in #13659 Aug 22, 2022

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 22, 2022

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark Mode should preempt key bindings, and work with anything that causes scrolling... #13533

Mark Mode should preempt key bindings, and work with anything that causes scrolling... #13533

Jaykul commented Jul 18, 2022

zadjii-msft commented Jul 18, 2022 •

edited

Loading

zadjii-msft commented Jul 19, 2022 •

edited by carlos-zamora

Loading

carlos-zamora commented Jul 20, 2022

carlos-zamora commented Aug 2, 2022 •

edited

Loading

carlocardella commented Aug 2, 2022

zadjii-msft commented Aug 3, 2022

ghost commented Sep 13, 2022

ghost commented Sep 13, 2022

Mark Mode should preempt key bindings, and work with anything that causes scrolling... #13533

Mark Mode should preempt key bindings, and work with anything that causes scrolling... #13533

Comments

Jaykul commented Jul 18, 2022

Windows Terminal version

Windows build number

Other Software

Steps to reproduce

Expected Behavior

Actual Behavior

zadjii-msft commented Jul 18, 2022 • edited Loading

zadjii-msft commented Jul 19, 2022 • edited by carlos-zamora Loading

carlos-zamora commented Jul 20, 2022

carlos-zamora commented Aug 2, 2022 • edited Loading

carlocardella commented Aug 2, 2022

zadjii-msft commented Aug 3, 2022

ghost commented Sep 13, 2022

ghost commented Sep 13, 2022

zadjii-msft commented Jul 18, 2022 •

edited

Loading

zadjii-msft commented Jul 19, 2022 •

edited by carlos-zamora

Loading

carlos-zamora commented Aug 2, 2022 •

edited

Loading