Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] Default theme updates #13554

Closed
4 tasks
zadjii-msft opened this issue Jul 21, 2022 · 2 comments · Fixed by #13743
Closed
4 tasks

[1.16] Default theme updates #13554

zadjii-msft opened this issue Jul 21, 2022 · 2 comments · Fixed by #13743
Assignees
@zadjii-msft @cinnamon-msft
Labels
Area-Theming Anything related to the theming of elements of the window Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.16

Comments

@zadjii-msft
Copy link
Member

From discussion with @cinnamon-msft et. al.

  • Dark theme by default (was system)
  • tab.background: terminalBackground
  • Change the tab row colors back to what they were pre-Controlsv2
    • This point I might be mis-remembering. I think the crux was "make the colors better", and we had freedom to do whatever we wanted.
    • The current dark tabRow.background is basically the same as the default scheme BG, and maybe that's good, maybe that's bad.
  • tabRow.unfocusedBackground set to something sensible in the default themes as well.

The 🌶️ rejected ides:

  • Default to mica on
    • Rejected cause this would disable vintage opacity
    • Rejected cause our Mica story isn't fleshed out yet
    • Rejected cause dark tabs in light OS theme with Mica titlebars has pretty low contrast overall.
  • ... with a non-acrylic, transparent control, so that you'd get the mica termcontrol body.
    • see all the above.
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Theming Anything related to the theming of elements of the window labels Jul 21, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 21, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 21, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 26, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 27, 2022
Merged
3 tasks
@zadjii-msft zadjii-msft mentioned this issue Aug 5, 2022
Closed
@zadjii-msft
Copy link
Member Author

zadjii-msft commented Aug 5, 2022 •
edited
Loading

🏗️ Work in progress 🏗️

originscreenshot (focused/unforcused if available)tab.backgroundtabRow.backgroundtabRow.unfocusedBackgroundWith terminalBackground & CampbellContrast (goal 3:1)
Edge Dark

image
image

(1.454:1 / 1.212:1)

#3b3b3b

#202020

#2e2e2e

image
image

 1.2:1 / 1.44:1
Terminal (Controlsv1)

image

#0c0c0c

#333333

 n/a

image

 1.548:1
Terminal (Controlsv2)

image

(1.342:1)

#282828

#0a0a0a

 n/a

image

 1.012:1
BG from edge unfocused,

inactive BG from controlsv1

 n/a

terminalBackground

#2e2e2e

#333333

image

image

 1.44:1 / 1.548:1
Light BG from edge unfocused,

inactive BG from controlsv1

 n/a

terminalBackground

#e8e8e8

#ffffff

 15.9:1

Notes:

  • Campbell's BG is #0c0c0c

@zadjii-msft zadjii-msft mentioned this issue Aug 5, 2022
Merged
@zadjii-msft zadjii-msft mentioned this issue Aug 15, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 15, 2022
@zadjii-msft zadjii-msft linked a pull request Aug 16, 2022 that will close this issue
Update the default themes for 1.16 #13743
Merged
zadjii-msft added a commit that referenced this issue Aug 31, 2022
@zadjii-msft
Add support for tab.unfocusedBackground (#13689)
f07b9e1 
Does what it sounds like on the label.

This is important, because when unset, the tab will use the active `Background` color to create an inactive BG, which maybe isn't what we want. Consider: 
- a bright cyan active BG,
- and `terminalBG` for the `tabRow` bg.

Without an unfocusedBackground setting, all the tabs will still appear cyan when unfocused, which is extra gross. 

As a judgement call, I made `terminalBackground` and `accent` use 30% opacity when set, to match the existing coloration. 

See also #13554. If we want to make the default theme `tab.background: terminalBackground`, we should make `tab.unfocusedBackground` transparent (`#00000000`) by default. Otherwise, a Campell (`#0c0c0c`) tab on _any_ tab row will still have a faint tab visible. 

* closes #13684
* closes #13246
* tested manually

This also does a lot of code shuffling, to get SettingsUI tabs to behave sensibly. We want those tabs to have (`#0c0c0c`, `#ffffff`) colored BGs for `terminalBackground` (see mail thread). 

We also don't want dark focused tabs colors, combined with light tab row colors, combined with transparent unfocused tabs, to result in unfocused tabs having white-on-white text. That's gross. So that's been added to this PR in b38b704.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Aug 31, 2022
zadjii-msft added a commit that referenced this issue Aug 31, 2022
@zadjii-msft
Update the default themes for 1.16 (#13743)
0b1b7e6 
More or less, as in #13554 

* Dark theme by default (was `system`)
  * Justification:
    > I think the interesting thing that we have today is that the color
    > scheme is dark by default, but our window theme is set to system.
    > System theme in Windows 11 is defaulted to light unless changed by
    > the user. Now, we have a conflict between the theme and color scheme
    > in Terminal.
    > 
    > I think our options become, make the color scheme match "default"
    > and set it to a light color scheme if the system theme is light, or
    > manually match the theme to the color scheme by setting it to dark.
    > 
    > Given that Terminal has historically had a black background with
    > its Campbell color scheme, for a consistent UI experience, I'm
    > voting to change the window theme to be dark by default as well.
* `tab.background: terminalBackground` 
* Change the tab row colors back to "what they were pre-Controlsv2" more
  or less
  - The ramp is based off of "Light tab row background from Edge's
    unfocused titlebar color, inactive tab row color BG from the
    controlsv1 colors"
* `tabRow.unfocusedBackground` set `Transparent`

Closes #13554
@ghost
Copy link

ghost commented Sep 13, 2022

🎉This issue was addressed in #13743, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

@cinnamon-msft cinnamon-msft

Labels
Area-Theming Anything related to the theming of elements of the window Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.16
Development

Successfully merging a pull request may close this issue.

Update the default themes for 1.16 microsoft/terminal
2 participants
@zadjii-msft @cinnamon-msft