Add tab.closeButton: activeOnly

[zadjii-msft]

TabView is a part of WinUI, and that code is available over at https://github.com/microsoft/microsoft-ui-xaml/

I want to know if it's even possible on the current version of TabView to actualize what that enum would represent?

Hm.

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Lines 2740 to 2772 in a9c3b77

	if (const auto theme = _settings.GlobalSettings().CurrentTheme())
	{
	const auto visibility = theme.Tab() ? theme.Tab().ShowCloseButton() : Settings::Model::TabCloseButtonVisibility::Always;
	for (const auto& tab : _tabs)
	{
	switch (visibility)
	{
	case Settings::Model::TabCloseButtonVisibility::Never:
	tab.TabViewItem().IsClosable(false);
	break;
	case Settings::Model::TabCloseButtonVisibility::Hover:
	tab.TabViewItem().IsClosable(true);
	break;
	default:
	tab.TabViewItem().IsClosable(true);
	break;
	}
	}
	switch (visibility)
	{
	case Settings::Model::TabCloseButtonVisibility::Never:
	_tabView.CloseButtonOverlayMode(MUX::Controls::TabViewCloseButtonOverlayMode::Auto);
	break;
	case Settings::Model::TabCloseButtonVisibility::Hover:
	_tabView.CloseButtonOverlayMode(MUX::Controls::TabViewCloseButtonOverlayMode::OnPointerOver);
	break;
	default:
	_tabView.CloseButtonOverlayMode(MUX::Controls::TabViewCloseButtonOverlayMode::Always);
	break;
	}
	}

Note

Walkthrough

• We could take that, turn that into a method.
• Call that method every time the active tab changes...
• ... or the set of tabs changes.
• Get rid of all the calls to _updateTabCloseButton, cause that only updates a single tab.
• Add logic in that method
  • Inside the loop, if the mode is ActiveOnly, and the tab is active, then IsClosable(true). else false
  • Outside the loop, set CloseButtonOverlayMode to Auto, probably a sensible default.

That sounds like it would work on paper. Wanna file a PR? 😄

Originally posted by @zadjii-msft in #3335 (comment)

[shourya5]

I have a question,for:

Call that method every time the active tab change
... or the set of tabs changes.

what would be the best way to implement this(as in check which tab(s) are active)?