Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display connection state in tab & add tab context menu entry for restarting connection #14909

Closed
2 tasks
xyang-zh opened this issue Feb 25, 2023 · 5 comments · Fixed by #15760
Closed
2 tasks
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@xyang-zh
Copy link

xyang-zh commented Feb 25, 2023

Environment

CPU AMD Ryzen 7 3700X 8-Core Processor 3.60 GHz
Memory 32.0 GB
OS 64-bit

Description of the new feature/enhancement

1、Add a status indicator to the tab indicates connection status
2、Add connect and disconnect buttons to the tab's Pop-up list(or somewhere)

Describe

The two functions above are closely linked and I have written them together
1、I want to disconnect the terminal from the background program without closing the terminal page (I need to see the contents,),and reconnect if necessary,more often than not, I prefer to reopen the current terminal page rather than closing it and creating another
Snipaste_2023-02-25_21-58-25
Add connect/disconnect buttons to above list(or somewhere)

2、Let's use an elegant dynamic icon to indicate the current connection status. Every time the connection is accidentally disconnected, the error report on the first line is of little use to me except for the last line which tells me to enter to reconnect (it's a strange feeling that the connection is now disconnected and the content is printed in the terminal...”)
like this:
Snipaste_2023-02-25_21-56-36

Proposed technical implementation details (optional)

It would be great to have both functions(connect/disconnect button) in one button


maintainer edit space:

Tasks

@xyang-zh xyang-zh added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 25, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 25, 2023
@carlos-zamora
Copy link
Member

Hi @Window-YANG. We're having a bit of trouble understanding how detach works and how it impacts the tab hosting that application. Could you please elaborate on that a bit?

As for the "restarting" aspect of this request, does #14060 sound like what you're looking for?

@carlos-zamora carlos-zamora added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 8, 2023
@xyang-zh
Copy link
Author

xyang-zh commented Mar 13, 2023

Hi @Window-YANG. We're having a bit of trouble understanding how detach works and how it impacts the tab hosting that application. Could you please elaborate on that a bit?

As for the "restarting" aspect of this request, does #14060 sound like what you're looking for?
Problem 1: restart。Refer to secureCRT.
reconnect1

Restart is 1409, but there are some shortcomings, 1409 confuses me: I can't find any place to actively disconnect (unless I close the terminal or enter a command in the terminal to exit the background program), so it's better to design a button ,no matter what the background program is, I can easily disconnect and reconnect with one click in the terminal

Proble 2: status
As for technical details like how to disconnect, I can't give much advice (one possible way: close the background program and recreate a new one?)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 13, 2023
@zadjii-msft
Copy link
Member

zadjii-msft commented Mar 13, 2023

Okay, I think I can see the cross-tabs here. There's a couple things we can do here:

I'll xlink with #6700 which has some similar thoughts in it.

Thanks for the suggestion!

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 13, 2023
@zadjii-msft zadjii-msft added this to the Backlog milestone Mar 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Tag-Fix Doesn't match tag requirements labels Mar 13, 2023
@zadjii-msft zadjii-msft changed the title Advanced Activity Indicator Display connection state in tab & add tab context menu entry for restarting connection Mar 13, 2023
@mpela81
Copy link
Contributor

mpela81 commented Jul 13, 2023

* When the active pane in a tab's connection state is `Closed`, we could add a "Restart connection" action to the tab context menu 

Do we want to add it to the tab's context menu, the (experimental) right-click context menu, or maybe both?

@zadjii-msft
Copy link
Member

both-is-good

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Jul 25, 2023
zadjii-msft pushed a commit that referenced this issue Sep 19, 2023
…ting connection (#15760)

## Summary of the Pull Request
When a connection is Closed, show an indicator in the respective tab.
When the active pane's connection is Closed, show a "Restart Connection"
action in the right-click context menu and in the tab context menu.

## Validation Steps Performed
- Force close a connection, check the indicator is shown in the tab.
- Right-click on pane shows the Restart Connection action if its
connection is closed
- Right-click on tab shows the Restart Connection action if the active
pane's connection is closed
- Indicator is cleared after connection is restarted (no panes in closed
state)

## PR Checklist
- [x] Closes #14909 
- [x] Tests added/passed
- [ ] Documentation updated
- [ ] Schema updated (if necessary)
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
Status: Done
4 participants