-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display connection state in tab & add tab context menu entry for restarting connection #14909
Comments
Hi @Window-YANG. We're having a bit of trouble understanding how detach works and how it impacts the tab hosting that application. Could you please elaborate on that a bit? As for the "restarting" aspect of this request, does #14060 sound like what you're looking for? |
Restart is 1409, but there are some shortcomings, 1409 confuses me: I can't find any place to actively disconnect (unless I close the terminal or enter a command in the terminal to exit the background program), so it's better to design a button ,no matter what the background program is, I can easily disconnect and reconnect with one click in the terminal Proble 2: status |
Okay, I think I can see the cross-tabs here. There's a couple things we can do here:
I'll xlink with #6700 which has some similar thoughts in it. Thanks for the suggestion! |
Do we want to add it to the tab's context menu, the (experimental) right-click context menu, or maybe both? |
…ting connection (#15760) ## Summary of the Pull Request When a connection is Closed, show an indicator in the respective tab. When the active pane's connection is Closed, show a "Restart Connection" action in the right-click context menu and in the tab context menu. ## Validation Steps Performed - Force close a connection, check the indicator is shown in the tab. - Right-click on pane shows the Restart Connection action if its connection is closed - Right-click on tab shows the Restart Connection action if the active pane's connection is closed - Indicator is cleared after connection is restarted (no panes in closed state) ## PR Checklist - [x] Closes #14909 - [x] Tests added/passed - [ ] Documentation updated - [ ] Schema updated (if necessary)
Environment
CPU AMD Ryzen 7 3700X 8-Core Processor 3.60 GHz
Memory 32.0 GB
OS 64-bit
Description of the new feature/enhancement
1、Add a status indicator to the tab indicates connection status
2、Add connect and disconnect buttons to the tab's Pop-up list(or somewhere)
Describe
The two functions above are closely linked and I have written them together
1、I want to disconnect the terminal from the background program without closing the terminal page (I need to see the contents,),and reconnect if necessary,more often than not, I prefer to reopen the current terminal page rather than closing it and creating another
Add connect/disconnect buttons to above list(or somewhere)
2、Let's use an elegant dynamic icon to indicate the current connection status. Every time the connection is accidentally disconnected, the error report on the first line is of little use to me except for the last line which tells me to enter to reconnect (it's a strange feeling that the connection is now disconnected and the content is printed in the terminal...”)
like this:
Proposed technical implementation details (optional)
It would be great to have both functions(connect/disconnect button) in one button
maintainer edit space:
Tasks
The text was updated successfully, but these errors were encountered: