Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more command doesn't advance to the next screen of text if I press spacebar #15116

Closed
adrastogi opened this issue Apr 5, 2023 · 7 comments · Fixed by #15122
Closed

more command doesn't advance to the next screen of text if I press spacebar #15116

adrastogi opened this issue Apr 5, 2023 · 7 comments · Fixed by #15122
Assignees
@lhecker
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.18

Comments

@adrastogi
Copy link
Collaborator

Windows Terminal version

1.18.902.0

Windows build number

10.0.23432.1000

Other Software

I tested this in cmd and PowerShell (version info below):

Name              : Microsoft.PowerShell
Publisher         : CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US
Architecture      : X64
ResourceId        :
Version           : 7.3.3.0

Steps to reproduce

  1. Within cmd.exe or pwsh.exe, and with a file that has at least a 'screenful' of text (e.g., call it foo.txt), try using more foo.txt to view the file's contents, one screenful at a time.
  2. After the first screenful is displayed, try pressing spacebar to advance to the next chunk.

Expected Behavior

The Terminal advances to the next page of text.

Actual Behavior

The Terminal remains at the current screen; I see the cursor flashing as normal. I also can't Ctrl+C out of this.

I don't see this behavior in retail Terminal (version 1.16.10262.0)- more behaves as I would expect there.
@adrastogi adrastogi added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 5, 2023
@DHowett
Copy link
Member

DHowett commented Apr 5, 2023

Aahhhh. This could be an OpenConsole crash? Can you check to see whether there's still an OpenConsole instance running for that terminal tab?

(The renderer is still working, evidenced by the cursor flashing.)

/cc @lhecker for potential buffer impact

@adrastogi
Copy link
Collaborator Author

Thanks for taking a look! OpenConsole is still running per Task Manager.

@Treit
Copy link

Treit commented Apr 5, 2023 •
edited
Loading

I am hitting this issue as well, 100% consistent repro (on 1.18.902.0.)

Pressing ctrl+break gets me 'unstuck' but all other key presses seem to be ignored.

@zadjii-msft
Copy link
Member

I wonder if this is from the linefeed changes in #14874

@DHowett
Copy link
Member

DHowett commented Apr 5, 2023

This also happens in OpenConsole...!

@DHowett DHowett added Severity-Blocking We won't ship a release like this! No-siree. Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Apr 5, 2023
@DHowett
Copy link
Member

DHowett commented Apr 5, 2023

Broken in a build made on 2023 day 81.
Works on 2023 33.
Broken on 2023 62.

@DHowett DHowett self-assigned this Apr 5, 2023
@DHowett
Copy link
Member

DHowett commented Apr 5, 2023 •
edited
Loading

This regressed in #14745 (TranslateUnicodeToOem)

I bet it's reading input with ReadConsoleInputA! 😉

/cc @lhecker

@DHowett DHowett removed their assignment Apr 5, 2023
@DHowett DHowett added the Product-Conhost For issues in the Console codebase label Apr 5, 2023
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 5, 2023
@carlos-zamora carlos-zamora added this to the Terminal v1.18 milestone Apr 5, 2023
@lhecker lhecker mentioned this issue Apr 5, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 5, 2023
DHowett pushed a commit that referenced this issue Apr 5, 2023
@lhecker
Return success if ReadCharacterInput read >0 characters (#15122)
5db8af6 
This is a regression caused by 599b550. If I'm reading `stream.cpp`
in cf87590 right, it returns `STATUS_SUCCESS` if `ReadCharacterInput`
read at least 1 character. I think? this PR makes the code behave
exactly equivalent. The old code is a bit of an "acquired taste"
so it's a bit hard to tell.

Closes #15116

## PR Checklist
* Run `more long_text_file.txt` in cmd
* Press Spacebar
* Scrolls down ✅
* Press Q
* Exits ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Return success if ReadCharacterInput read >0 characters microsoft/terminal
6 participants
@DHowett @lhecker @Treit @adrastogi @carlos-zamora @zadjii-msft