Command Palette key bindings are unreadable in Dark theme with light accent color

[Molkree]

Windows Terminal version

1.16.10261.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

1. Set the Terminal theme to dark.
2. Enable "Automatically pick an accent colour from my background" in Windows settings. This image should do the trick. Or set it manually to Turquoise (41, 190, 204; #29BECC).
3. Open Command Palette.
4. Navigate to some entry with key binding.
   

Key binding colours don't change in the Light theme too so maybe someone can find such accent colour so that it also becomes unreadable, not sure:

This is a bit similar to #6892 (my accent colour is almost the same! 😄)

Expected Behavior

Key bindings' colour gets inverted if needed as action text colour does.

Actual Behavior

Key bindings' colour doesn't change depending on the selection background colour.

[237dmitry]

Key bindings' colour doesn't change depending on the selection background colour.

Yes, but keybindings are visible:

[zadjii-msft]

Is there a secret step 0 here that's "set the OS to High Contrast Mode"?

This might be tricky. I wonder if there's a brush that's better for "text on top of the accent color", that we could set with like, a VisualState or something, only in HC mode...

[Molkree]

keybindings are visible

@237dmitry, hm, my UI looks different, as you can see in the screenshots above (you only have accent colour as a short strip on the left and for me the whole background of selection changes). Is there a setting that controls this? I can't find anything obvious on the Appearance page of the settings. Are you on the same version of Terminal? Windows 10?

Is there a secret step 0 here that's "set the OS to High Contrast Mode"?

@zadjii-msft, I don't have High Contrast enabled in Windows (I have just checked it).

[zadjii-msft]

INTERESTING.

Looks like ListView itself changed in Windows 11:

Left is a Win10 VM, and right is on Win11.

I would have assumed that just saying we were using Controlsv2 would have applied there as well (even on Windows 10), but perhaps there's something about the new style that isn't supported on windows 10.

I dunno what to do about this. I don't really want to try and have a conditional hack for "Only on Windows 10, do we also want to apply this other VisualStateGroup to the Command Palette items". That sounds tricky to do right in XAML, or annoying in codebehind. But I also don't know how to get the Win11 styles to work on Win10. Hmmm

[zadjii-msft]

Note

Walkthrough

Probably the easiest way to do this would be to just add a .Background() to this border:

terminal/src/cascadia/TerminalApp/CommandPalette.xaml

Lines 73 to 79 in ca5834e

	<Border Grid.Column="2"
	Padding="2,0,2,0"
	HorizontalAlignment="Right"
	VerticalAlignment="Center"
	AutomationProperties.AccessibilityView="Raw"
	Style="{ThemeResource KeyChordBorderStyle}"
	Visibility="{x:Bind Item.KeyChordText, Mode=OneWay, Converter={StaticResource CommandKeyChordVisibilityConverter}}">

and use like, the CommandPalette background there, so that it appears transparent, but actually isn't.

(this was an off the cuff suggestion during triage, and we all thought it was a good idea)

[Random9ine]

@zadjii-msft Can I try my hand with this issue?

[zadjii-msft]

@Random9ine always!

[Random9ine]

@zadjii-msft Unfortunately away from my desktop for the summer and didn't realize there's no way to run Win10 VMs on M1 MBP anymore. Don't think I'll be able to get to this for awhile

[RickleAndMortimer]

Hey everyone, is it alright if I try taking a look at this issue?

[DHowett]

Absolutely.

[RanjanTheDoer]

Hey is this issue fixed? If not I would like to work on it. please assign me

[zadjii-msft]

Oh, huh. It looks like this was merged after all! Looks like this merged in #15677, but we never looped back and linked this PR to it! Sorry about that 😕