Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening command palette from new tab dropdown dismisses immediately #15305

Closed
ianjoneill opened this issue May 6, 2023 · 2 comments · Fixed by #15340
Closed

Opening command palette from new tab dropdown dismisses immediately #15305

ianjoneill opened this issue May 6, 2023 · 2 comments · Fixed by #15340
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.18

Comments

@ianjoneill
Copy link
Contributor

Windows Terminal version

main 10c6206

Windows build number

10.0.22621.1555

Other Software

No response

Steps to reproduce

  1. Open terminal
  2. Click new tab dropdown
  3. Select Command Palette

Expected Behavior

The command palette opens and is usable.

Actual Behavior

The command palette opens and then disappears. Opening the command palette via the keyboard shortcut works fine.

CommandPalette.mp4
@ianjoneill ianjoneill added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 6, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone May 8, 2023
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 8, 2023
@zadjii-msft
Copy link
Member

psychic debug: was #15077

@ianjoneill
Copy link
Contributor Author

That does look highly suspicious

zadjii-msft added a commit that referenced this issue May 12, 2023
@zadjii-msft
Don't dismiss the command palette when the new tab menu closes
9226086 
Transient UIs are hard.

Regressed in #15077.

Closes #15305
@zadjii-msft zadjii-msft mentioned this issue May 12, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label May 12, 2023
DHowett pushed a commit that referenced this issue May 12, 2023
@zadjii-msft
Don't dismiss the command palette when the new tab menu closes (#15340)
1bf2fcb 
Transient UIs are hard.

Regressed in #15077.

Closes #15305
DHowett pushed a commit that referenced this issue May 12, 2023
@zadjii-msft @DHowett
Don't dismiss the command palette when the new tab menu closes (#15340)
704be80 
Transient UIs are hard.

Regressed in #15077.

Closes #15305

(cherry picked from commit 1bf2fcb)
Service-Card-Id: 89193705
Service-Version: 1.18
@zadjii-msft zadjii-msft mentioned this issue Jul 17, 2023
Open
DHowett pushed a commit that referenced this issue Aug 2, 2023
@zadjii-msft @DHowett
Don't dismiss the command palette when the new tab menu closes (#15340)
c3bdf74 
Transient UIs are hard.

Regressed in #15077.

Closes #15305

(cherry picked from commit 1bf2fcb)
Service-Card-Id: 89899296
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Don't dismiss the command palette when the new tab menu closes microsoft/terminal
2 participants
@ianjoneill @zadjii-msft