-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.18] Certain fonts will cause a renderer error (MesloLGM NF, Cascadia Code Nerd Font) #15416
Comments
Could you share your settings.json file/? This might be partially the font thing from #15403 |
I'm sorry for causing the issue - We only noticed it mere hours before publishing 1.18 and I already opened a PR to fix it: #15403. If you can and don't mind, it'd be great if you could use an alternative font just for a week, because it would help us find other potential bugs you might encounter. I personally for instance like using Delugia. Otherwise, I hope we'll be able to ship a fix soon! |
Collected notes from other threads: Fixes:
If you're experiencing this, you can
@lhecker also built a Windows Terminal Preview version that integrates the previous 3 AtlasEngine bug fixes, 2 of which might be relevant here: #15403 and #15425. You can download it here: blob.hecker.io/sharex/Microsoft.WindowsTerminalPreview_1.18.1443.0_8wekyb3d8bbwe.msixbundle I'm using my own personal domain because I don't want to expose my internal work addresses. However the file is properly cryptographically signed by Microsoft. |
Confirming that the version you posted does not have the reported problems. |
`til::rect`'s truthiness check (= rect is valid) returns `false` for any rects that have negative coordinates. This makes sense for buffer handling, but breaks AtlasEngine, where glyph coordinates can go out of bounds and it's entirely valid for that to happen. Closes #15416 ## Validation Steps Performed * Use MesloLGM NF and print NF glyphs in the first row * Text rendering, selection, etc., still works ✅ --------- Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
`til::rect`'s truthiness check (= rect is valid) returns `false` for any rects that have negative coordinates. This makes sense for buffer handling, but breaks AtlasEngine, where glyph coordinates can go out of bounds and it's entirely valid for that to happen. Closes #15416 ## Validation Steps Performed * Use MesloLGM NF and print NF glyphs in the first row * Text rendering, selection, etc., still works ✅ --------- Co-authored-by: Dustin L. Howett <duhowett@microsoft.com> (cherry picked from commit a9f34e3) Service-Card-Id: 89326794 Service-Version: 1.18
I'm not going to lie, I didn't even have the non-preview version installed and didn't even realize I was running the preview version. This thing is so rock solid for me, I wish I had it on my Linux machine. Keep up the excellent work! |
I can confirm the rendering error with Nerd Font v3 (Cascadia Cove Nerd Font Mono) when using neovim with nerd font v3 symbols. After turning off Nerd Font v3 was released in late April this year. So there might be more undiscovered bugs with the new utf8 characters introduced in Nerd Font v3 specs. |
Just tried v1.18.1462.0 and indeed the problem is fixed. Thanks a lot for fixing this so quickly. |
@zadjii-msft -- still seeing some differences in rendering. This is original: ![]() This is 1.18.1462.0 ![]() I can't figure out how to give you a simple reproduction, but the easiest would be to install oh-my-zsh and go through the powerlevel10k installation wizard which does a whole bunch of interesting things to the terminal. |
@withinboredom Mind filing a new issue? That looks like a much more minor graphical error, vs the pretty substantial issue this thread was originally tracking. Thanks! |
Will do, thanks for the fast response @zadjii-msft ! |
Windows Terminal version
1.18.1421.0
Windows build number
10.0.19045.2965
Other Software
oh-my-posh v16.8.0
Ubuntu 22.04.02 LTS
Steps to reproduce
It seems impossible to create a screenshot with the snipping tool because when the focus on WT is lost, the renderer catches up immediately.
Tearing of a tab created an error the very first time, but couldn't reproduce it anymore.
Expected Behavior
No response
Actual Behavior
Various rendering issues
The text was updated successfully, but these errors were encountered: