Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal might use i18n strings from multiple languages, if the preferred lang is not one WT is fully localized into #15596

Open
mataha opened this issue Jun 23, 2023 · 6 comments
Labels
Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@mataha
Copy link

mataha commented Jun 23, 2023


Important

📌 Plan of record: #15596 (comment)
We should try to avoid using resources from languages we're only partially localized into (if that's even possible)


Windows Terminal version

1.17.11461.0

Windows build number

10.0.19045.3086

Other Software

N/A

Steps to reproduce

Open Windows Terminal. That's it.

System languages installed (in order of preference):

  • Polish (display)
  • Japanese
  • Korean
  • Russian

Expected Behavior

Windows Terminal opens in my preferred system language (Polish), falling back to English (as it is the de facto lingua franca) if that's not possible.

Actual Behavior

I'd like to provide more details, but I can't stop laughing.

image

@mataha mataha added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 23, 2023
@lhecker
Copy link
Member

lhecker commented Jun 26, 2023

I honestly don't even know how to begin working on this. 😄
We don't really control this - we just tell WinUI our set of localized strings and it picks the right one based on language preference. It seems to usually work, given that this is (unless I'm mistaken) the first time we've seen such a bug report. I also can't find anything like that over at https://github.com/microsoft/microsoft-ui-xaml.

@DHowett
Copy link
Member

DHowett commented Jun 26, 2023

LOL. Thanks for filing! I think I know how to approach this one.

If your list of preferred languages is:

  • Polish (display)
  • Japanese
  • Korean
  • Russian

We are not going to choose English under those circumstances. English is not one of your preferred languages!

For a quick fix, you can override the display language of Windows Terminal's UI with a setting on the Appearance page. 😄

The main issue is that Terminal isn't localized in Polish... but some of its components are, Ugh.

The secondary issue is that MRT (the modern resource "thing" (not its official name)) doesn't do whole-application language selection; it actually does per-resource language selection.

The tertiary issue is that we do mark our package as supporting Polish, for this darn thing:

image

(That menu item gets localized into 88 languages, where the rest of Terminal only gets 13. Yeah. Not great.)

I'd like to provide more details, but I can't stop laughing.

(Do you mind if I share this with the i18n team? They'll get a kick out of it :D)

@zadjii
Copy link

zadjii commented Jun 26, 2023

This is a good sign that partial localizations work though, for #10667

@carlos-zamora
Copy link
Member

We should see if we can configure language fallback with MRT

@carlos-zamora carlos-zamora added this to the Terminal v1.20 milestone Jun 28, 2023
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 28, 2023
@mataha
Copy link
Author

mataha commented Jul 1, 2023

I honestly don't even know how to begin working on this. 😄 We don't really control this - we just tell WinUI our set of localized strings and it picks the right one based on language preference. It seems to usually work, given that this is (unless I'm mistaken) the first time we've seen such a bug report. I also can't find anything like that over at https://github.com/microsoft/microsoft-ui-xaml.

I don't think there are many users with three - or even two - preferred system languages. Even less that would file a bug report here.

The secondary issue is that MRT (the modern resource "thing" (not its official name)) doesn't do whole-application language selection; it actually does per-resource language selection.

That's what I thought - buttons are in Polish, most of the translated resources are in Japanese (with leftovers in Korean) and the rest is in English...

(Do you mind if I share this with the i18n team? They'll get a kick out of it :D)

Feel free to do so, by all means!

@VectorBCO
Copy link

VectorBCO commented Nov 29, 2023

i have a similar issue when terminal chose russian for some reason
#16395

@zadjii-msft zadjii-msft changed the title Windows Terminal takes i18n too seriously Terminal might use i18n strings from multiple languages, if the preferred lang is not one WT is fully localized into Feb 7, 2024
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.20, Backlog Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

7 participants