Windows Terminal crashes when dragging a tab #15689
Comments
mwaltersbmc
added
Issue-Bug
|
Also tested with Terminal 1.17.11461.0 on Windows 10.0.19045.3086 and the problem does not happen |
|
Can you share the crash dump with us/? There are some notes on this wiki page. Thanks! |
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
zadjii-msft
added
Severity-Crash
zadjii-msft
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
added
the
No-Recent-Activity
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Dump file provided privately |
microsoft-github-policy-service
bot
added
Needs-Attention
|
EDIT gah I finally found it in the spam folder. That filter's a little too aggressive some times (and not nearly aggressive enough others) |
|
Just to add - I have a colleague, also using W11, that can reproduce the issue using the same steps. |
no dumps in watson. stackOh boy that looks like a XAML crash. Great. I'll try and find anything else like it. Any chance this repros with the WinUI 2 Gallery? There's a page in that app that's got a TabView for testing |
carlos-zamora
removed
the
Needs-Attention
|
Out of curiosity, are you running the Terminal elevated? Or with UAC disabled (the EnableLua=0 thing)/? |
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
It's a corporate PC that has BeyondTrust privilege management software installed so I don't have options to run elevated. |
microsoft-github-policy-service
bot
added
Needs-Attention
|
Re WinUI - I installed and used the TabView samples under the Navigation section and was able to rearrange tabs on all the examples without a crash. I also launched the sample app and it too worked. |
WELL That's sure an interesting observation. Sorry to be just seemingly shooting in the dark on this. We've really ruled out most of the... usual... things that cause crashes like this, so I'm a bit shooting blindly. As a test, can you rearrange tabs with the |
|
I set ctrl+u to be move tab forward and then move tab backwards. In both cases it worked as expected and did not cause a crash. |
|
Okay, well at least that very specifically reduces the problem space to the drag/drop interaction, and not necessarily the "move tabs" implementation. But it also doesn't repro in the XAML controls gallery. We're not doing too much different than what they do, especially in 1.17. Hmm. Maybe my contacts on XAML will have some insight as to why I couldn't find the stowed exception, or how to get it out of the dump. That might help point a finger. |
|
@zadjii-msft FYI What I meant is the manipulation of |
|
WELL that certainly would seem to point the finger at us.
... Nah that seems like a dead end.
Oh I mean, that's certainly bound for pain. But at this point,
we haven't done any tomfoolery with the TabItems yet, other than just add one. Gonna keep picking through this dump but I can't find anything useful. |
`GetAt` can throw if the index is out of range. We don't check that in some places. This fixes some of those. I don't think this will take care of #15689, but it might help?
|
I've just downloaded and tested Windows Terminal Preview v1.19.2831.0 and it fixes this issue. I can click on tabs and drag them to reorder or break out to a new window without crashing. Thank you! Tested on the same Windows 11 system where Version: 1.19.2682.0 crashes attempting the same actions. I downloaded the new x64 release zip, unpacked to a new directory, created several SSH profiles that I frequently use and tested the actions that would fail on earlier versions. No crashes. |
🙃Well. That sure doesn't make any sense. Maybe this really was #16016 after all? @seamonstr you too? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
That's exciting... I'm on holiday at the moment, so I don't have access to
the machine that shows the issue. I'll update on Monday!
S
…On Thu, 26 Oct 2023 at 15:27, Mike Griese ***@***.***> wrote:
I've just downloaded and tested Windows Terminal Preview v1.19.2831.0 and
it fixes this issue
🙃
Well. That sure doesn't make any sense. Maybe this really was #16016
<#16016> after all? @seamonstr
<https://github.com/seamonstr> you too?
—
Reply to this email directly, view it on GitHub
<#15689 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6SI6CKEIMV6BVXUDJ7N6DYBJXNTAVCNFSM6AAAAAA2FTB4R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRGI2DGMZZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry, nope… 2831 still crashes after the teeniest little drag within a tab.
Happy to supply whatever info I can to debug…
…On Fri, 27 Oct 2023 at 07:27, Simon Woodward ***@***.***> wrote:
That's exciting... I'm on holiday at the moment, so I don't have access to
the machine that shows the issue. I'll update on Monday!
S
On Thu, 26 Oct 2023 at 15:27, Mike Griese ***@***.***>
wrote:
> I've just downloaded and tested Windows Terminal Preview v1.19.2831.0 and
> it fixes this issue
>
> 🙃
>
> Well. That sure doesn't make any sense. Maybe this really was #16016
> <#16016> after all? @seamonstr
> <https://github.com/seamonstr> you too?
>
> —
> Reply to this email directly, view it on GitHub
> <#15689 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AA6SI6CKEIMV6BVXUDJ7N6DYBJXNTAVCNFSM6AAAAAA2FTB4R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRGI2DGMZZG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Some further testing shows something a bit odd - using the WindowsTerminal app from the release download Microsoft.WindowsTerminalPreview_1.19.2831.0_x64.zip file the problem does not happen. I just unzipped the archive and double clicked on the binary to start the app. Dragging tabs does not cause a crash. However, having updated my already installed Terminal preview app using Microsoft.WindowsTerminalPreview_1.19.2831.0_8wekyb3d8bbwe.msixbundle, I do get a crash when dragging tabs! |
|
wat that's insane. I have no idea why that would make a difference. The package identity itself? That's insane. Especially since the WinUI 2 Gallery would also have package identity... |
|
It may be related to permissions. I have the working wt.exe in c:\temp and if I open a DOS or PowerShell command prompt in that dir and run wt.exe then I can drag tabs without a crash. If I open the command prompt with "Run as administrator" launch wt.exe then dragging causes a crash. |
Oh, elevated (as admin) vs unelevated might be a valuable data point here. There's literally endless issues with elevated drag/drop. I don't think you're supposed to be able to do that at all actually |
|
When I launch Terminal from the GUI it shows in Task Manager as running from C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.19.2831.0_x64__8wekyb3d8bbwe However
But I can dir the contents. I've worked around the problem by creating a copy of the working set up in c:\apps\wt and running it from there and I can drag without issue - may be worth a shot @seamonstr |
Tested on a Windows 10 system - run terminal as normal user and I can drag tabs without issue. Run elevated via right click Run As Admin and tab dragging doesn't work. No crash, dragging just doesn't do anything. Perhaps the BeyondTrust software is doing something odd with the way it handles elevated permissions. The workaround of running the Terminal binary from the x64 release download rather than installed via the store is working for me so I'm happy to close this. |
FWIW, that's unfortunately by design: #6661. The drag-drop service will CRASH YOUR APP if you run an app elevated and try to drag/drop tabs. Perhaps that actually leads to the root cause here? Maybe BeyondTrust is getting up in the drag/drop service's business, and causing the drag/drop service to crash, bringing the Terminal down with it. We pre-emptively disable dragging if we know we're elevated (a known case that will crash us), but maybe there's something else unique going on here. Then again, I dunno why it would act differently for the store package vs the unpackaged version 🤷 |
|
The bug is still in v1.19.3172.0 |
|
The bug is still in v1.20.11271.0 |
|
Always replicating with 1.20.11215.0 WindowsTerminal.exe.25164.dmp.zip |
excuse me what? I was pretty confident that tab dragging is disabled entirely when running as Admin1. If it's not, then yea - the Terminal will always crash if a tab is dragged in an admin window. Footnotes
|
|
Don't know what to say; in Admin mode tabs can be reordered, and it crashes 🤷 |
|
Indeed.
My long term battling of this issue was that terminal was ALWAYS running as
admin (I suspect something our corporate IT people set up), and I had to
super careful to not drag a tab instinctively because I’d lose all my
sessions in the ensuing crash!
…On Mon, 3 Jun 2024 at 13:31, Simone Galleni ***@***.***> wrote:
Don't know what to say; in Admin mode tabs *can* be reordered, and it
crashes 🤷
And no matter if it's the ZIP or the Store-installed version: it's the
same for both.
—
Reply to this email directly, view it on GitHub
<#15689 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6SI6CEDZKZNJBCQ7BNCUDZFRO2HAVCNFSM6AAAAAA2FTB4R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGA4DKNJYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Windows Terminal version
1.17.11461.0 and 1.18.1462.0
Windows build number
10.0.22000.1936
Other Software
No response
Steps to reproduce
Open Terminal and create a session of any type eg Command Prompt, ssh connection, Powershell
Left click on session tab and drag
Expected Behavior
Reorder tabs
Actual Behavior
Terminal crashes with no visible error message
Crashdumps are created in %LOCALAPPDATA%\CrashDumps
The text was updated successfully, but these errors were encountered: