Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Scheme - Camphell]: Name is not defined for 'Delete Color Scheme' button. #15984

Closed
Priyanka-Chauhan123 opened this issue Sep 18, 2023 · 0 comments · Fixed by #15994
Closed

[Color Scheme - Camphell]: Name is not defined for 'Delete Color Scheme' button. #15984

Priyanka-Chauhan123 opened this issue Sep 18, 2023 · 0 comments · Fixed by #15994
Assignees
@carlos-zamora
Labels
A11yCO Accessibility tracking A11ySev1 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Disability-All Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Milestone
Terminal v1.20

Comments

@Priyanka-Chauhan123
Copy link
Collaborator

Priyanka-Chauhan123 commented Sep 18, 2023 •
edited
Loading

Windows Terminal version

1.19.2481.0

Windows build number

23529.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 23529.1000)
App: Windows Terminal Preview

Steps to reproduce

**Repro Steps: **

1.Open Windows Terminal.
2.Open Settings page using 'Ctr+,'
3. Navigate to the 'Color Scheme' and activate 'Add new'.
4. Now navigate to 'Delete color scheme' button and observe the issue.

**User Experience: **
Screen Reader users will not know the exact reference of the control, if name is not defined for the 'Delete color scheme' button.

MAS Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachment:

Name is not defined for 'Delete Color Scheme' button.zip

Expected Behavior

Name should be defined for 'Delete Color Scheme' button.

Actual Behavior

Name is not defined for 'Delete Color Scheme' button.
@Priyanka-Chauhan123 Priyanka-Chauhan123 added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yCO Accessibility tracking A11ySev1 Accessibility tracking A11yMAS Accessibility tracking Disability-All Accessibility tracking labels Sep 18, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 self-assigned this Sep 18, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 added A11yWCAG Accessibility tracking and removed A11yMAS Accessibility tracking labels Sep 18, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed their assignment Sep 18, 2023
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 18, 2023
@carlos-zamora carlos-zamora self-assigned this Sep 18, 2023
@carlos-zamora carlos-zamora added this to the Terminal v1.20 milestone Sep 18, 2023
@carlos-zamora carlos-zamora mentioned this issue Sep 18, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Sep 18, 2023
zadjii-msft pushed a commit that referenced this issue Sep 19, 2023
@carlos-zamora
Add Auto Prop Name to 'Delete Color Scheme' button (#15994)
3550e19 
Since the "delete color scheme" button is filled with an icon and a Text
Box, the text is not automatically exposed as the autoProp.Name for the
button. We have to do it manually just like we do for "delete profile".

Validated manually using accessibility insights

Closes #15984
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 19, 2023
DHowett pushed a commit that referenced this issue Sep 22, 2023
@carlos-zamora @DHowett
Add Auto Prop Name to 'Delete Color Scheme' button (#15994)
ed16c32 
Since the "delete color scheme" button is filled with an icon and a Text
Box, the text is not automatically exposed as the autoProp.Name for the
button. We have to do it manually just like we do for "delete profile".

Validated manually using accessibility insights

Closes #15984

(cherry picked from commit 3550e19)
Service-Card-Id: 90584974
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
A11yCO Accessibility tracking A11ySev1 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Disability-All Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Projects
None yet
Milestone
Terminal v1.20
Development

Successfully merging a pull request may close this issue.

Add Auto Prop Name to 'Delete Color Scheme' button microsoft/terminal
2 participants
@carlos-zamora @Priyanka-Chauhan123