Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Allow WSL distros and other shells to load metadata into terminal #1690

Closed
sirredbeard opened this issue Jun 28, 2019 · 2 comments · Fixed by #7632
Closed

Feature Request: Allow WSL distros and other shells to load metadata into terminal #1690

sirredbeard opened this issue Jun 28, 2019 · 2 comments · Fixed by #7632
Assignees
@PankajBhojwani
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.7

Comments

@sirredbeard
Copy link

The names of WSL distros in terminal are currently sourced from their names registered in the WSL API.

This is problematic for us in particular because we changed distro names and this leads to user confusion. See microsoft/WSL#4241. Some of the other WSL distros have unfriendly names as their WSL API names, so this is not unique to us.

We would propose that Windows Terminal allow WSL distros and other Store packages, such as the Python package, to override their default WSL listing.

One option would be to include a .json in the WSL distro template that is added to Windows Terminal on installation with a custom name, the distro executable name (e.g. Pengwin.exe), link to an icon file, and possibly a custom default color scheme.

Thank you for your consideration.
@sirredbeard sirredbeard added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 28, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 28, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jul 1, 2019
@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 1, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 1, 2019
@zadjii-msft zadjii-msft mentioned this issue Sep 9, 2019
Closed
@zadjii-msft
Copy link
Member

oh my gosh

@PankajBhojwani This is proto-extensions.

There was an issue this whole time

@PankajBhojwani PankajBhojwani mentioned this issue Oct 30, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 30, 2020
@zadjii-msft zadjii-msft mentioned this issue Nov 2, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Dec 17, 2020
Closed
@ghost ghost closed this as completed in #7632 Feb 19, 2021
@ghost ghost removed the In-PR This issue has a related PR label Feb 19, 2021
ghost pushed a commit that referenced this issue Feb 19, 2021
@PankajBhojwani
Add support for "fragment extensions" (#7632)
654c0cc 
Support for fragment extensions, according to the implementation
outlined in #7584 (which calls them proto extensions.)

See #7584 for more information.

## Validation Steps Performed
Self-testing by creating the folder 
`%LOCALAPPDATA%\Microsoft\Windows Terminal\Fragments`
and adding a json file into it to modify and add profiles

Also self-tested with an app extension

Closes #1690
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 19, 2021
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #7632, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Aug 31, 2021
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.7
Development

Successfully merging a pull request may close this issue.

Add support for "fragment extensions" microsoft/terminal
5 participants
@bitcrazed @DHowett-MSFT @zadjii-msft @PankajBhojwani @sirredbeard