Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-seeded actions from userDefaults.json should be removed after adding IDs #17133

Closed
lhecker opened this issue Apr 25, 2024 · 0 comments · Fixed by #17162
Closed

Pre-seeded actions from userDefaults.json should be removed after adding IDs #17133

lhecker opened this issue Apr 25, 2024 · 0 comments · Fixed by #17162
Assignees
@PankajBhojwani
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@lhecker
Copy link
Member

lhecker commented Apr 25, 2024 •
edited
Loading

Windows Terminal version

1.21.1094.0

Windows build number

10.0.26092.0

Other Software

No response

Steps to reproduce

  • Launch the latest Canary
  • Open settings.json

Expected Behavior

  • The 4 actions we put into every user's settings.json should get converted to new keybindings (just "keys" and "id", no "type", etc.)
  • The existing settings.json files need to be cleaned up

Actual Behavior

Settings file contains "User.copy.644BA8F2", etc.
@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Priority-1 A description (P1) labels Apr 25, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.22 milestone Apr 25, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 25, 2024
@PankajBhojwani PankajBhojwani mentioned this issue May 9, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 4, 2024
@PankajBhojwani
Refactor ActionMap and Command to use ActionIDs (#17162)
ece0c04 
As outlined in #16816, refactor `ActionMap` to use the new action IDs
added in #16904

## Validation steps performed

- [x] Legacy style commands are parsed correctly (and rewritten to the
new format)
- [x] Actions are still layered correctly and their IDs can be used to
'overwrite' actions in earlier layers
- [x] Keybindings that refer to an ID defined in another layer work
correctly
- [x] User-defined actions without an ID have one generated for them
(and their settings file is edited with it)
- [x] Schema updated

Refs #16816 
Closes #17133
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 4, 2024
@kachick kachick mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

Successfully merging a pull request may close this issue.

Refactor ActionMap and Command to use ActionIDs microsoft/terminal
3 participants
@lhecker @carlos-zamora @PankajBhojwani