Output containing OSC sequences (e.g. shell integration) is not rendered (regression)

[krzysdz]

Windows Terminal version

432dfcc and later

Windows build number

10.0.19045.4291

Other Software

No response

Steps to reproduce

1. Enable shell integration in oh-my-posh or set your PowerShell prompt to

   function prompt {
       "$([char]0x1b)]133;D`a$([char]0x1b)]133;A`a> $([char]0x1b)]133;B`a"
   }

2. Open a new pane/window to load the profile
3. (Optionally) Try pressing Ctrl+C and normal characters

Expected Behavior

No response

Actual Behavior

The prompt (and ^C sometimes too) is not rendered until a printable character is entered from keyboard or the window is resized (resizing doesn't always help).

2024-05-08.02-42-19.mp4

2024-05-08.02-50-05.mp4

This regression was introduced in 432dfcc (#17194)

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

• [REGR #3956] Terminal incorrectly splits part of escape sequence (#4131), similarity score: 0.78
• OSC sequences in prompt get front loaded (#11220), similarity score: 0.75

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[krzysdz]

@j4james ping

[j4james]

I'm very sorry about this. I suspect it might be something else that needs to be reset in XtermEngine::StartPaint when returning early. But if it's not obvious, and we need a quick fix, feel free to revert PR #17194. That bug probably affects far fewer people.

[zadjii-msft]

Ah yep yeah I can confirm this too. It's... pretty rough, though I honestly don't know how many people have shell integration set up.

@lhecker you wanna take a look at this, see if we can't come up with a more clever fix than just reverting #17194? If we can't, then I'll probably make the argument that we need to revert that later this week.

[lhecker]

Hmm I wonder if it has to do with the _cursorMoved changes. Since it was always true this always caused a render pass. Restoring the old _cursorMoved = true code does make everything work again.