The suggestions UI counts the current command as one of the recent commands #17243
Labels
In-PR
This issue has a related PR
Needs-Tag-Fix
Doesn't match tag requirements
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Comments
microsoft-github-policy-service
bot
added
Needs-Triage
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
This comment was marked as resolved.
This comment was marked as resolved.
zadjii-msft
removed
the
Needs-Author-Feedback
github-merge-queue bot
pushed a commit
that referenced
this issue
May 13, 2024
This is fallout from #16937. * Typing a command then backspacing the chars then asking for suggestions would think the current commandline ended with spaces, making filtering very hard. * The currently typed command would _also_ appear in the command history, which isn't useful. I actually did TDD for this and wrote the test first, then confirmed again running through the build script, I wasn't hitting any of the earlier issues. Closes #17241 Closes #17243
DHowett
pushed a commit
that referenced
this issue
Jun 7, 2024
This is fallout from #16937. * Typing a command then backspacing the chars then asking for suggestions would think the current commandline ended with spaces, making filtering very hard. * The currently typed command would _also_ appear in the command history, which isn't useful. I actually did TDD for this and wrote the test first, then confirmed again running through the build script, I wasn't hitting any of the earlier issues. Closes #17241 Closes #17243 (cherry picked from commit bf8a647) Service-Card-Id: 92638413 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
okay the github task item to issue promotion leaves it blank, grrr
The text was updated successfully, but these errors were encountered: