Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.22: wt save should save the command in the current window, if at all possible #17366

Closed
Tracked by #13000
zadjii-msft opened this issue Jun 4, 2024 · 0 comments · Fixed by #17758
Closed
Tracked by #13000

1.22: wt save should save the command in the current window, if at all possible #17366

zadjii-msft opened this issue Jun 4, 2024 · 0 comments · Fixed by #17758
Assignees
@zadjii-msft
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.22

Comments

@zadjii-msft
Copy link
Member

follow-up from #16513.

If you don't have the terminal set to glom automatically, then a new terminal will pop up to handle a wt x-save. It shouldn't.
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. labels Jun 4, 2024
@zadjii-msft zadjii-msft added this to the Terminal v1.22 milestone Jun 4, 2024
@zadjii-msft zadjii-msft self-assigned this Jun 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 4, 2024
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 5, 2024
@zadjii-msft zadjii-msft mentioned this issue Aug 20, 2024
Open
zadjii-msft added a commit that referenced this issue Aug 21, 2024
@zadjii-msft
x-save the commandline in the current window
22866d5 
By manually setting the `_windowTarget` to `0`, we can make sure to toss
`x-save` commandlines at the current terminal window (so long as there is one).

Edge cases:
* You passed other subcommands with `x-save`: Well, we'll do whatever we would
  have normally done for multiple subcommands. We won't `x-save` in the current
  window, we'll obey your settings. That seems to make sense
* You ran `wt x-save` without an open Terminal window: We'll open a terminal
  window during the process of handling it. That seems sensible.

Closes #17366
@zadjii-msft zadjii-msft mentioned this issue Aug 21, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 21, 2024
zadjii-msft added a commit that referenced this issue Sep 9, 2024
@zadjii-msft
Add Feature_SaveSnippet to preview builds
a65b2ae 
whoops. This should have been in preview after I sorted out #17366
@zadjii-msft zadjii-msft mentioned this issue Sep 9, 2024
Merged
lhecker pushed a commit that referenced this issue Sep 9, 2024
@zadjii-msft
Add Feature_SaveSnippet to preview builds (#17881)
c699a46 
whoops. This should have been in preview after I sorted out #17366


----

I did this one on GH so let's hope CI works
DHowett pushed a commit that referenced this issue Sep 16, 2024
@zadjii-msft @DHowett
Add Feature_SaveSnippet to preview builds (#17881)
c129e79 
whoops. This should have been in preview after I sorted out #17366

----

I did this one on GH so let's hope CI works

(cherry picked from commit c699a46)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgS66Co
Service-Version: 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.22
Development

Successfully merging a pull request may close this issue.

x-save the commandline in the current window microsoft/terminal
2 participants
@carlos-zamora @zadjii-msft